REST API calls to store URL metrics fail when pretty permalinks aren't enabled #1567
Labels
[Plugin] Optimization Detective
Issues for the Optimization Detective plugin
[Type] Bug
An existing feature is broken
Milestone
When pretty permalinks aren't enabled, Optimization Detective sends the URL metrics data to the
/index.php?rest_route=%2Foptimization-detective%2Fv1%2Furl-metrics%3Astore&_wpnonce=d6ef56f704
. This ends up causing the request to fail with:This is because
rest_route
is returned, unexpectedly, as one of the params when calling$request->get_params()
:performance/plugins/optimization-detective/storage/rest-api.php
Lines 131 to 136 in ddf297d
The quick fix would be to
unset( $data['rest_route'] )
, but it would be better if the params we obtain are exclusively from the JSON body.This code is also being touched in #1373 where the issue is also occurring.
Granted, likely only a miniscule number of sites don't have pretty permalinks enabled, so this isn't a critical issue.
The text was updated successfully, but these errors were encountered: