Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter menu: Hover text color overrides focus state on current menu item #687

Open
trushaamin opened this issue May 6, 2024 · 1 comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Type] Bug Something isn't working

Comments

@trushaamin
Copy link

trushaamin commented May 6, 2024

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'wordpress.org'
  2. Click on 'My Patterns'
  3. Scroll down to 'Public button'
  4. See error button hover focus not proper working

Expected behavior
After logging into WordPress.org, we navigated to the "Patterns" option and located the "My Patterns" button at the top. Upon selecting this option, we clicked the "Public" button and noticed that the hover focus was not working properly.

Screenshots

Button Hover Focus

Desktop (please complete the following information):

  • OS: iOS
  • Browser chrome, safari
  • Version macOS 10.15.7

Additional context
check the "My patterns" and then the "Public" button hover focus check.

@ryelle
Copy link
Contributor

ryelle commented May 6, 2024

I can reproduce this — on the "current" menu item, when both :focus and :hover are active, the text and background are both black. You can see this happen if you click the active menu item again. The background should probably use the light-grey hover background.

Screenshot 2024-05-06 at 10 30 23 AM

On other menu items, the focus state overrides the hover state, this should probably also be fixed so that :hover:focus has the light grey background too.

@ryelle ryelle added [Type] Bug Something isn't working [Component] Theme The frontend of the pattern directory, pattern lists UI labels May 6, 2024
@ryelle ryelle moved this to 📋 To do in WordPress.org Redesign May 6, 2024
@ryelle ryelle changed the title On Button hover focus not properly working Filter menu: Hover text color overrides focus state on current menu item May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Type] Bug Something isn't working
Projects
Status: 📋 To do
Development

No branches or pull requests

2 participants