Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update catalog indexer worker from psycopg2 to psycopg (v3) #5159

Closed
dhruvkb opened this issue Nov 12, 2024 · 0 comments · Fixed by #5161
Closed

Update catalog indexer worker from psycopg2 to psycopg (v3) #5159

dhruvkb opened this issue Nov 12, 2024 · 0 comments · Fixed by #5161
Assignees
@dhruvkb
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Nov 12, 2024

Problem

pyscopg v3 is a newer, faster version of the psycopg2 library. We are already using psycopg v3 in the API.

openverse/api/pyproject.toml

Line 34 in 1b64d10

"psycopg >=3.1.18, <4",

Description

The indexer worker should also be updated to use psycopg v3 from the current psycopg2.

openverse/indexer_worker/pyproject.toml

Line 22 in 1b64d10

"psycopg2 ~= 2.9",

Additional context

Refer to the docs for differences and migration guidelines.
@dhruvkb dhruvkb added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Nov 12, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Nov 12, 2024
@dhruvkb dhruvkb self-assigned this Nov 13, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Nov 13, 2024
@dhruvkb dhruvkb mentioned this issue Nov 13, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Nov 13, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Openverse Backlog
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update psycopg2 to psycopg (v3) WordPress/openverse
1 participant
@dhruvkb