Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the breadcrumb as the draggable handle #8764

Closed
wants to merge 21 commits into from
Closed

Use the breadcrumb as the draggable handle #8764

wants to merge 21 commits into from

Commits on Aug 20, 2018

  1. Debug: colors are fun!

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    add68b9 View commit details
    Browse the repository at this point in the history

  2. Debug: make the draggable area visible

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    d4f6fa7 View commit details
    Browse the repository at this point in the history

  3. We're going to get rid of side grabs 

    So we don't need these.
    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    d06670f View commit details
    Browse the repository at this point in the history

  4. Match breadcrumb positioning

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    c119acb View commit details
    Browse the repository at this point in the history

  5. Position the handle in the top right corner, alongside the label

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    32a465f View commit details
    Browse the repository at this point in the history

  6. Expose the handle, hide the contents

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    97f17ea View commit details
    Browse the repository at this point in the history

  7. Dont make the handle ever visible. 

    The drag handle no longer overlaps the block content div,
so we can't render a placeholder in the handle itself.
We need to figure somethingelse out.
    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    9c694b6 View commit details
    Browse the repository at this point in the history

  8. Add grab affordance

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    123d37b View commit details
    Browse the repository at this point in the history

  9. HACK: PoC to improve the draggable indicator 

    This tweaks the dashicon viewBox to render a not too embarrasing
draggable indicator. This needs fixing.
    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    a37bcde View commit details
    Browse the repository at this point in the history

  10. Use opacity to communicate what block is being dragged. 

    Previous to this refactor, it used to be a div inside the block wrapper
that would become visible when the block was being dragged. That
div would appear as grey. By refactoring the drag handler to the
breadcrumb we no longer have that div, so we seek to use
a different technique to communicate the same behavior.

I also think is nicer to show the original content.
    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    fcd43b7 View commit details
    Browse the repository at this point in the history

  11. Create withDraggable HOC

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    ebfe05a View commit details
    Browse the repository at this point in the history

  12. Refactor breadcrumb to use withDraggable HOC

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    ca3dbf6 View commit details
    Browse the repository at this point in the history

  13. Deprecate wp.components.Draggable in favor of wp.components.withDragg… 

    …able
    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    4cea178 View commit details
    Browse the repository at this point in the history

  14. fixup docs

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    47f02fe View commit details
    Browse the repository at this point in the history

  15. Remove block-draggable 

    it's only used internally by the block-list component.
    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    74d1b9c View commit details
    Browse the repository at this point in the history

  16. Add comment to z-index value

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    77f7ef1 View commit details
    Browse the repository at this point in the history

  17. Make cursor affordance visible

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    26ca9bf View commit details
    Browse the repository at this point in the history

  18. withDraggable injects initDragging instead of onDragStart 

    The new name clarifies the purpose and allows the original component
to have passed the onDragStart property by some parent component.
    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    ac43bb3 View commit details
    Browse the repository at this point in the history

  19. Breadcrumb notifies parent on drag start and end

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    7c37b06 View commit details
    Browse the repository at this point in the history

  20. Move deprecations to 3.7 version

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    9d4793a View commit details
    Browse the repository at this point in the history

  21. The breadcrumb should not be shown above overlays

    @oandregal
    oandregal committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    9999a4f View commit details
    Browse the repository at this point in the history