From 9a08cabfecd93b3aa44ec2f234b6c0515b7879a7 Mon Sep 17 00:00:00 2001 From: dhruvikpatel18 Date: Thu, 15 Oct 2026 22:52:33 +0530 Subject: [PATCH 1/2] Data Controls: Convert the tests to TypeScript --- .../data-controls/src/test/{index.js => index.ts} | 8 +++++--- packages/data-controls/tsconfig.build.json | 12 ++++++++++++ packages/data-controls/tsconfig.json | 10 +++------- tsconfig.build.json | 2 +- tsconfig.json | 1 + 5 files changed, 22 insertions(+), 11 deletions(-) rename packages/data-controls/src/test/{index.js => index.ts} (75%) create mode 100644 packages/data-controls/tsconfig.build.json diff --git a/packages/data-controls/src/test/index.js b/packages/data-controls/src/test/index.ts similarity index 75% rename from packages/data-controls/src/test/index.js rename to packages/data-controls/src/test/index.ts index b22f3ca08990e2..306e3b4f87f43d 100644 --- a/packages/data-controls/src/test/index.js +++ b/packages/data-controls/src/test/index.ts @@ -11,12 +11,14 @@ describe( 'controls', () => { mockedTriggerFetch.mockClear(); } ); it( 'invokes the triggerFetch function', () => { - controls.API_FETCH( { request: '' } ); + controls.API_FETCH( { request: { path: '' } } ); expect( mockedTriggerFetch ).toHaveBeenCalledTimes( 1 ); } ); it( 'invokes the triggerFetch function with the passed in request', () => { - controls.API_FETCH( { request: 'foo' } ); - expect( mockedTriggerFetch ).toHaveBeenCalledWith( 'foo' ); + controls.API_FETCH( { request: { path: 'foo' } } ); + expect( mockedTriggerFetch ).toHaveBeenCalledWith( { + path: 'foo', + } ); } ); } ); } ); diff --git a/packages/data-controls/tsconfig.build.json b/packages/data-controls/tsconfig.build.json new file mode 100644 index 00000000000000..fc33b902d4a832 --- /dev/null +++ b/packages/data-controls/tsconfig.build.json @@ -0,0 +1,12 @@ +{ + "$schema": "https://json.schemastore.org/tsconfig.json", + "extends": "@wordpress/monorepo-tools/tsconfig/base.json", + "compilerOptions": { + "types": [ "gutenberg-env" ] + }, + "references": [ + { "path": "../api-fetch/tsconfig.build.json" }, + { "path": "../data" }, + { "path": "../deprecated/tsconfig.build.json" } + ] +} diff --git a/packages/data-controls/tsconfig.json b/packages/data-controls/tsconfig.json index fc33b902d4a832..f5ece948ea1f5e 100644 --- a/packages/data-controls/tsconfig.json +++ b/packages/data-controls/tsconfig.json @@ -1,12 +1,8 @@ { "$schema": "https://json.schemastore.org/tsconfig.json", - "extends": "@wordpress/monorepo-tools/tsconfig/base.json", + "extends": "@wordpress/monorepo-tools/tsconfig/dev.base.json", "compilerOptions": { - "types": [ "gutenberg-env" ] + "types": [ "gutenberg-env", "gutenberg-vitest-test-env" ] }, - "references": [ - { "path": "../api-fetch/tsconfig.build.json" }, - { "path": "../data" }, - { "path": "../deprecated/tsconfig.build.json" } - ] + "references": [ { "path": "./tsconfig.build.json" } ] } diff --git a/tsconfig.build.json b/tsconfig.build.json index 204daa5631d306..1866083dc18b86 100644 --- a/tsconfig.build.json +++ b/tsconfig.build.json @@ -21,7 +21,7 @@ { "path": "packages/core-abilities" }, { "path": "packages/core-data/tsconfig.build.json" }, { "path": "packages/data" }, - { "path": "packages/data-controls" }, + { "path": "packages/data-controls/tsconfig.build.json" }, { "path": "packages/dataviews/tsconfig.build.json" }, { "path": "packages/date/tsconfig.build.json" }, { "path": "packages/deprecated/tsconfig.build.json" }, diff --git a/tsconfig.json b/tsconfig.json index 6bc339500647ed..5429158a30f958 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -16,6 +16,7 @@ { "path": "packages/compose" }, { "path": "packages/connectors" }, { "path": "packages/core-data" }, + { "path": "packages/data-controls" }, { "path": "packages/dataviews" }, { "path": "packages/dataviews/tsconfig.stories.json" }, { "path": "packages/date" }, From a77e459f2043115fe6a01fce812c55972e39e378 Mon Sep 17 00:00:00 2001 From: dhruvikpatel18 Date: Thu, 15 Oct 2026 23:20:02 +0530 Subject: [PATCH 2/2] Data Controls: Add CHANGELOG entry --- packages/data-controls/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/data-controls/CHANGELOG.md b/packages/data-controls/CHANGELOG.md index 88c17d89a40159..9d48389c46d0a6 100644 --- a/packages/data-controls/CHANGELOG.md +++ b/packages/data-controls/CHANGELOG.md @@ -6,6 +6,10 @@ - Raise the minimum required Node.js version to `>=22.13.0`, for stable `require(esm)` support ([#84313](https://github.com/WordPress/gutenberg/pull/84313)). +### Internal + +- Convert the tests to TypeScript, and split tsconfig into a build project and a default dev project so the tests are type checked without publishing their declarations ([#84852](https://github.com/WordPress/gutenberg/pull/84852)). + ## 4.57.0 (2026-10-07) ### Bug Fixes