From 1da54eb0f40e5a9ced276d3127d859fa3fcf9d27 Mon Sep 17 00:00:00 2001 From: Lena Morita Date: Wed, 2 Sep 2026 07:21:20 +0900 Subject: [PATCH 1/3] UI: Name Combobox and Select story triggers --- .../combobox/stories/index.story.tsx | 42 +++++++++---------- .../primitives/select/stories/index.story.tsx | 35 +++++++++------- 2 files changed, 41 insertions(+), 36 deletions(-) diff --git a/packages/ui/src/form/primitives/combobox/stories/index.story.tsx b/packages/ui/src/form/primitives/combobox/stories/index.story.tsx index d8d4aec5f24bd3..9114a1456855bd 100644 --- a/packages/ui/src/form/primitives/combobox/stories/index.story.tsx +++ b/packages/ui/src/form/primitives/combobox/stories/index.story.tsx @@ -37,10 +37,6 @@ const meta: Meta< typeof Combobox.Root > = { 'Combobox.Clear': Combobox.Clear, }, parameters: { - // FIXME: The trigger has no visible label and relies on aria-label - // (button-name). - // See: https://github.com/WordPress/gutenberg/issues/81596 - a11y: { test: 'todo' }, componentStatus: { status: 'use-with-caution', whereUsed: 'global', @@ -61,10 +57,10 @@ export const Default: Story = { args: { items: ITEMS, children: [ - , + ,
- +
No results found. @@ -91,10 +87,14 @@ export const Compact: Story = { defaultValue: ITEMS[ 0 ], items: ITEMS, children: [ - , + ,
- +
No results found. @@ -128,9 +128,6 @@ export const DetachedInline: Story = { // The input keeps focus and arrow keys move through the options, so // the scrollable list is reachable by keyboard. a11y: { - // Storybook merges parameters, so `test` must be set here to - // override the warning-only default from `meta`. - test: 'error', config: { rules: [ { id: 'scrollable-region-focusable', enabled: false }, @@ -210,10 +207,13 @@ export const Creatable: Story = { : ITEMS } > - +
- +
No results found. @@ -339,10 +339,10 @@ function AsyncItemsTemplate( { }, 500 ); } } > - +
- +
+ { ( item: FixtureItem ) => ( ,
- +
@@ -470,10 +470,10 @@ export const Grouped: Story = { args: { items: GROUPED_ITEMS, children: [ - , + ,
- +
No results found. @@ -527,7 +527,7 @@ export const WithCustomZIndex: Story = { defaultValue: ITEMS[ 0 ], items: ITEMS, children: [ - , + ,
- +
diff --git a/packages/ui/src/form/primitives/select/stories/index.story.tsx b/packages/ui/src/form/primitives/select/stories/index.story.tsx index 6b7ed734adf555..50560ee2b4dffb 100644 --- a/packages/ui/src/form/primitives/select/stories/index.story.tsx +++ b/packages/ui/src/form/primitives/select/stories/index.story.tsx @@ -14,10 +14,6 @@ const meta: Meta< typeof Select.Root > = { 'Select.Item': Select.Item, }, parameters: { - // FIXME: The trigger has no visible label and relies on aria-label - // (button-name). - // See: https://github.com/WordPress/gutenberg/issues/81596 - a11y: { test: 'todo' }, componentStatus: { status: 'use-with-caution', whereUsed: 'global', @@ -38,7 +34,7 @@ export const Default: Story = { args: { items: defaultItems, children: [ - , + , { defaultItems.map( ( item ) => ( @@ -54,7 +50,7 @@ export const Compact: Story = { args: { ...Default.args, children: [ - , + , { defaultItems.map( ( item ) => ( @@ -77,7 +73,12 @@ export const Compact: Story = { export const Minimal: Story = { args: { children: [ - , + , { Array.from( { length: 6 }, ( _, index ) => ( group.items ), children: [ - , + , { groupedItems.map( ( group ) => ( @@ -155,7 +156,11 @@ export const WithCustomPlaceholder: Story = { args: { items: defaultItems, children: [ - , + , { defaultItems.map( ( item ) => ( @@ -183,7 +188,7 @@ export const WithNullValueOption: Story = { args: { items: nullValueOptionItems, children: [ - , + , { nullValueOptionItems.map( ( item ) => ( , + , { overflowItems.map( ( item ) => ( @@ -256,7 +261,7 @@ export const Disabled: Story = { args: { ...Default.args, children: [ - , + , { defaultItems.map( ( item ) => ( @@ -287,7 +292,7 @@ export const WithDisabledItem: Story = { args: { items: disabledItemItems, children: [ - , + , { disabledItemItems.map( ( item ) => ( + { ( item ) => ( , + , Date: Wed, 2 Sep 2026 07:43:49 +0900 Subject: [PATCH 2/3] UI: Name Checkbox and Input story controls --- .../form/primitives/checkbox/stories/index.story.tsx | 11 +++++++---- .../src/form/primitives/input/stories/index.story.tsx | 8 +++----- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/packages/ui/src/form/primitives/checkbox/stories/index.story.tsx b/packages/ui/src/form/primitives/checkbox/stories/index.story.tsx index 09baa7bb87a947..07448e13bc47e6 100644 --- a/packages/ui/src/form/primitives/checkbox/stories/index.story.tsx +++ b/packages/ui/src/form/primitives/checkbox/stories/index.story.tsx @@ -5,9 +5,6 @@ const meta: Meta< typeof Checkbox > = { title: 'Design System/Components/Form/Primitives/Checkbox', component: Checkbox, parameters: { - // FIXME: Stories show the checkbox primitive without a visible label (aria-toggle-field-name). - // See: https://github.com/WordPress/gutenberg/issues/81596 - a11y: { test: 'todo' }, componentStatus: { status: 'use-with-caution', whereUsed: 'global', @@ -21,29 +18,35 @@ export default meta; type Story = StoryObj< typeof Checkbox >; export const Default: Story = { - args: {}, + args: { + 'aria-label': 'Option', + }, }; export const Checked: Story = { args: { + ...Default.args, defaultChecked: true, }, }; export const Indeterminate: Story = { args: { + ...Default.args, indeterminate: true, }, }; export const Disabled: Story = { args: { + ...Default.args, disabled: true, }, }; export const DisabledChecked: Story = { args: { + ...Default.args, disabled: true, defaultChecked: true, }, diff --git a/packages/ui/src/form/primitives/input/stories/index.story.tsx b/packages/ui/src/form/primitives/input/stories/index.story.tsx index ab2558e6426cf6..154c9e72ed2848 100644 --- a/packages/ui/src/form/primitives/input/stories/index.story.tsx +++ b/packages/ui/src/form/primitives/input/stories/index.story.tsx @@ -32,6 +32,7 @@ type Story = StoryObj< typeof Input >; export const Default: Story = { args: { placeholder: 'Placeholder', + 'aria-label': 'Value', }, }; @@ -42,19 +43,16 @@ export const Default: Story = { export const WithPrefix: Story = { args: { placeholder: 'username', + 'aria-label': 'Username', prefix: @, }, }; export const WithSuffixControl: Story = { args: { + 'aria-label': 'Value', suffix: InputLayoutWithSuffixControl.args?.suffix, }, - parameters: { - // FIXME: Story shows Input without a visible label (label). - // See: https://github.com/WordPress/gutenberg/issues/81596 - a11y: { test: 'todo' }, - }, }; export const Disabled: Story = { From 2890fa3f1d2bd9b9881a7b4c8d1d60a07c1afd13 Mon Sep 17 00:00:00 2001 From: Lena Morita Date: Wed, 2 Sep 2026 07:50:08 +0900 Subject: [PATCH 3/3] UI: Name Textarea, Autocomplete, and SearchableChipSelect stories --- .../autocomplete/stories/index.story.tsx | 37 +++++++++++++++---- .../stories/index.story.tsx | 2 + .../textarea/stories/index.story.tsx | 1 + 3 files changed, 33 insertions(+), 7 deletions(-) diff --git a/packages/ui/src/form/primitives/autocomplete/stories/index.story.tsx b/packages/ui/src/form/primitives/autocomplete/stories/index.story.tsx index 3633d50ff70172..24bd4031ae3e68 100644 --- a/packages/ui/src/form/primitives/autocomplete/stories/index.story.tsx +++ b/packages/ui/src/form/primitives/autocomplete/stories/index.story.tsx @@ -60,7 +60,11 @@ export const Default: Story = { args: { items: URLS, children: [ - , + , No matching items. @@ -109,7 +113,10 @@ export const OpenOnlyOnMatch: Story = { } } filteredItems={ filteredItems } > - + @@ -217,7 +224,7 @@ function AsyncItemsTemplate( { }, 500 ); } } > - + - +
@@ -515,7 +527,11 @@ export const WithCustomZIndex: Story = { args: { items: URLS, children: [ - , + , , + , No matching items. @@ -636,7 +656,10 @@ export const Grid: Story = { render: function Template( args ) { return ( - +
( ; export const Default: Story = { args: { placeholder: 'Placeholder', + 'aria-label': 'Value', }, };