diff --git a/packages/block-library/src/tab/save.js b/packages/block-library/src/tab/save.js index 43454a04c2dcf8..752f24dfe038f6 100644 --- a/packages/block-library/src/tab/save.js +++ b/packages/block-library/src/tab/save.js @@ -8,7 +8,9 @@ export default function save( { attributes } ) { const tabPanelId = anchor; - const blockProps = useBlockProps.save(); + const blockProps = useBlockProps.save( { + role: 'tabpanel', + } ); const innerBlocksProps = useInnerBlocksProps.save( blockProps ); return
; diff --git a/packages/block-library/src/tabs-menu-item/save.js b/packages/block-library/src/tabs-menu-item/save.js index d67dffd14e6a25..38bd68dcae0910 100644 --- a/packages/block-library/src/tabs-menu-item/save.js +++ b/packages/block-library/src/tabs-menu-item/save.js @@ -1,7 +1,6 @@ /** * WordPress dependencies */ -import { __ } from '@wordpress/i18n'; import { useBlockProps } from '@wordpress/block-editor'; export default function save( { attributes } ) { @@ -27,20 +26,14 @@ export default function save( { attributes } ) { } // useBlockProps.save includes all core style engine classes and styles - // We add our custom classes and the hidden attribute for PHP template extraction + // The button content is replaced by PHP during rendering, so we output + // an empty button as a template. const blockProps = useBlockProps.save( { className: 'wp-block-tabs-menu-item__template', style: customColorStyles, - hidden: true, type: 'button', role: 'tab', } ); - return ( - - ); + return + diff --git a/test/integration/fixtures/blocks/core__tabs-menu-item.parsed.json b/test/integration/fixtures/blocks/core__tabs-menu-item.parsed.json index 876070e849df0f..7bbc0fa87c486d 100644 --- a/test/integration/fixtures/blocks/core__tabs-menu-item.parsed.json +++ b/test/integration/fixtures/blocks/core__tabs-menu-item.parsed.json @@ -3,9 +3,9 @@ "blockName": "core/tabs-menu-item", "attrs": {}, "innerBlocks": [], - "innerHTML": "\n\n", + "innerHTML": "\n\n", "innerContent": [ - "\n\n" + "\n\n" ] } ] diff --git a/test/integration/fixtures/blocks/core__tabs-menu-item.serialized.html b/test/integration/fixtures/blocks/core__tabs-menu-item.serialized.html index 269cb74475024b..95abbe8b36c521 100644 --- a/test/integration/fixtures/blocks/core__tabs-menu-item.serialized.html +++ b/test/integration/fixtures/blocks/core__tabs-menu-item.serialized.html @@ -1,3 +1,3 @@ - + diff --git a/test/integration/fixtures/blocks/core__tabs-menu.html b/test/integration/fixtures/blocks/core__tabs-menu.html index 9ea80385fd9a6c..7daf799dceaa91 100644 --- a/test/integration/fixtures/blocks/core__tabs-menu.html +++ b/test/integration/fixtures/blocks/core__tabs-menu.html @@ -1,11 +1,11 @@
- + - +
diff --git a/test/integration/fixtures/blocks/core__tabs-menu.parsed.json b/test/integration/fixtures/blocks/core__tabs-menu.parsed.json index 26544117ae34c1..582785ebc658cd 100644 --- a/test/integration/fixtures/blocks/core__tabs-menu.parsed.json +++ b/test/integration/fixtures/blocks/core__tabs-menu.parsed.json @@ -7,18 +7,18 @@ "blockName": "core/tabs-menu-item", "attrs": {}, "innerBlocks": [], - "innerHTML": "\n\t\n\t", + "innerHTML": "\n\t\n\t", "innerContent": [ - "\n\t\n\t" + "\n\t\n\t" ] }, { "blockName": "core/tabs-menu-item", "attrs": {}, "innerBlocks": [], - "innerHTML": "\n\t\n\t", + "innerHTML": "\n\t\n\t", "innerContent": [ - "\n\t\n\t" + "\n\t\n\t" ] } ], diff --git a/test/integration/fixtures/blocks/core__tabs-menu.serialized.html b/test/integration/fixtures/blocks/core__tabs-menu.serialized.html index 47a5dad676ddcc..0f2cebe1424b1f 100644 --- a/test/integration/fixtures/blocks/core__tabs-menu.serialized.html +++ b/test/integration/fixtures/blocks/core__tabs-menu.serialized.html @@ -1,9 +1,9 @@
- + - +
diff --git a/test/integration/fixtures/blocks/core__tabs.html b/test/integration/fixtures/blocks/core__tabs.html index 3aef5c57fc46a2..029f0b13a96bbe 100644 --- a/test/integration/fixtures/blocks/core__tabs.html +++ b/test/integration/fixtures/blocks/core__tabs.html @@ -3,7 +3,7 @@
- +
@@ -11,7 +11,7 @@
-
+

Pariatur commodo sint mollit. Veniam Lorem labore voluptate fugiat. Ad nulla est labore cillum cillum qui nostrud do incididunt eiusmod.

@@ -19,11 +19,11 @@ -
+
-
+
diff --git a/test/integration/fixtures/blocks/core__tabs.parsed.json b/test/integration/fixtures/blocks/core__tabs.parsed.json index 78bcd77b76ea9f..918a0cfe31a0c2 100644 --- a/test/integration/fixtures/blocks/core__tabs.parsed.json +++ b/test/integration/fixtures/blocks/core__tabs.parsed.json @@ -11,9 +11,9 @@ "blockName": "core/tabs-menu-item", "attrs": {}, "innerBlocks": [], - "innerHTML": "\n\t\t\n\t\t", + "innerHTML": "\n\t\t\n\t\t", "innerContent": [ - "\n\t\t\n\t\t" + "\n\t\t\n\t\t" ] } ], @@ -44,9 +44,9 @@ ] } ], - "innerHTML": "\n\t\t
\n\t\t\t\n\t\t
\n\t\t", + "innerHTML": "\n\t\t
\n\t\t\t\n\t\t
\n\t\t", "innerContent": [ - "\n\t\t
\n\t\t\t", + "\n\t\t
\n\t\t\t", null, "\n\t\t
\n\t\t" ] @@ -57,9 +57,9 @@ "label": "Tab 2" }, "innerBlocks": [], - "innerHTML": "\n\t\t
\n\t\t", + "innerHTML": "\n\t\t
\n\t\t", "innerContent": [ - "\n\t\t
\n\t\t" + "\n\t\t
\n\t\t" ] }, { @@ -68,9 +68,9 @@ "label": "Tab 3" }, "innerBlocks": [], - "innerHTML": "\n\t\t
\n\t\t", + "innerHTML": "\n\t\t
\n\t\t", "innerContent": [ - "\n\t\t
\n\t\t" + "\n\t\t
\n\t\t" ] } ], diff --git a/test/integration/fixtures/blocks/core__tabs.serialized.html b/test/integration/fixtures/blocks/core__tabs.serialized.html index fa2d1c3952ebfe..3e8aafc0da6261 100644 --- a/test/integration/fixtures/blocks/core__tabs.serialized.html +++ b/test/integration/fixtures/blocks/core__tabs.serialized.html @@ -1,23 +1,23 @@
- +
-
+

Pariatur commodo sint mollit. Veniam Lorem labore voluptate fugiat. Ad nulla est labore cillum cillum qui nostrud do incididunt eiusmod.

-
+
-
+