Repository navigation
Conversation
|
Size Change: +1.85 kB (+0.06%) Total Size: 3.05 MB
ℹ️ View Unchanged
|
scruffian
added
[Type] Enhancement
jeryj
force-pushed
the
add/overlay-classes-to-template
branch
from
January 14, 2026 14:49
566b8b6 to
424872b
Compare
Contributor
|
Closing in favour of #74653 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
If a navigation block is used inside a navigation overlay, it should be kept open rather than collapsing, when viewed inside the template part editor.
Closes #74590
Why?
On the front end, navigation blocks inside the overlay are automatically opened, so we should do the same thing in the editor as well, so they match.
How?
Moves the
isWithinNavigationOverlayselector to a new file and uses that to determine that we are in that editing context. When in that context we update the block so that its open.Testing Instructions
Screenshots or screencast