Skip to content

Upgrade storybook to v9 #74143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manzoorwanijk merged 29 commits into from
Dec 31, 2025
Merged

Upgrade storybook to v9 #74143

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
36d5495
Upgrade Storybook from v8 to v9
manzoorwanijk Dec 21, 2025
f0c93be
Disable type-checking for node_modules
manzoorwanijk Dec 21, 2025
3044b29
Move Storybook setup to use isolated workspace
manzoorwanijk Dec 21, 2025
11701f6
Fix lints in package.json
manzoorwanijk Dec 21, 2025
cc70e07
Update lockfile
manzoorwanijk Dec 21, 2025
3c853c5
Fix incompatible storybook addons
manzoorwanijk Dec 21, 2025
f0fe62a
Replace the incompatible source-link and badge addons with compatible…
manzoorwanijk Dec 22, 2025
cf29e70
Fix lints
manzoorwanijk Dec 22, 2025
d32d81b
Remove unused packages
manzoorwanijk Dec 22, 2025
f90ba6d
Merge branch 'trunk' into upgrade/storybook
manzoorwanijk Dec 24, 2025
2695698
Add TODO for storybook eslint rule override
manzoorwanijk Dec 24, 2025
bf40d92
We can still import from @storybook/react when declared as a dependency
manzoorwanijk Dec 24, 2025
7429d0a
Disable all default links from source link addon
manzoorwanijk Dec 27, 2025
db8aa30
Use badge data directly in manager
manzoorwanijk Dec 27, 2025
da7930f
Fix hook dependency
manzoorwanijk Dec 27, 2025
78f5e55
Local addons cannot use JSX in newer Storybook versions
manzoorwanijk Dec 27, 2025
8d68352
Remove @storybook/addon-toolbars from storybook instance
manzoorwanijk Dec 27, 2025
db27e26
Merge branch 'trunk' into upgrade/storybook
manzoorwanijk Dec 27, 2025
cba331b
Update package-lock.json
manzoorwanijk Dec 27, 2025
ae96989
Merge branch 'trunk' into upgrade/storybook
manzoorwanijk Dec 27, 2025
4dc5057
Merge branch 'trunk' into upgrade/storybook
manzoorwanijk Dec 30, 2025
388e4b7
Revert the workspace conversion changes
manzoorwanijk Dec 30, 2025
a86eac2
Fix storybook:dev race condition with dev script
manzoorwanijk Dec 30, 2025
f97748b
Merge branch 'trunk' into upgrade/storybook
manzoorwanijk Dec 30, 2025
35664e0
Fix lints after merge conflicts
manzoorwanijk Dec 30, 2025
123a4f4
Merge branch 'trunk' into upgrade/storybook
manzoorwanijk Dec 31, 2025
a1fddc5
Remove unused ts-expect-error comments
manzoorwanijk Dec 31, 2025
116eb7b
Detach stdout event handler and allow clean up on early termination
manzoorwanijk Dec 31, 2025
aec4ce0
Revert changes to bin/dev.mjs
manzoorwanijk Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
We can still import from @storybook/react when declared as a dependency 
This reduces the number of changes in this branch
  • Loading branch information
@manzoorwanijk
manzoorwanijk committed Dec 24, 2025
commit bf40d923c4470b3dbd264d7ae32b9c316eb9a6bc
6 changes: 6 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@
"uuid": "^9.0.1"
},
"devDependencies": {
"@storybook/react": "9.1.17",
"timezone-mock": "^1.3.6"
},
"peerDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/alignment-matrix-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/angle-picker-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/animate/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/badge/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/base-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/border-box-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import type { ComponentProps } from 'react';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/border-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import type { ComponentProps } from 'react';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/box-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/button-group/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/button/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import type { ReactNode } from 'react';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/calendar/stories/date-calendar.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
ar,
sv,
} from 'date-fns/locale';
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/calendar/stories/date-range-calendar.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import {
ar,
sv,
} from 'date-fns/locale';
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';
/**
* WordPress dependencies
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/card/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/checkbox-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/circular-option-picker/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
/**
* WordPress dependencies
*/
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/color-indicator/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/color-palette/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/color-picker/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/combobox-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/composite/legacy/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/composite/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/confirm-dialog/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/custom-gradient-picker/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import { fn } from 'storybook/test';
/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/custom-select-control-v2/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/custom-select-control/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/date-time/stories/date-time.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/date-time/stories/date.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/date-time/stories/time.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/disabled/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/divider/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/draggable/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';
import type { DragEvent } from 'react';
import { fn } from 'storybook/test';

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/drop-zone/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/dropdown-menu/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/dropdown/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryObj } from '@storybook/react-webpack5';
import type { Meta, StoryObj } from '@storybook/react';
import { fn } from 'storybook/test';

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/duotone-picker/stories/duotone-picker.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* WordPress dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/duotone-picker/stories/duotone-swatch.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/elevation/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/external-link/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/flex/stories/index.story.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/**
* External dependencies
*/
import type { Meta, StoryFn } from '@storybook/react-webpack5';
import type { Meta, StoryFn } from '@storybook/react';

/**
* Internal dependencies
Expand Down
Loading
Loading