Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try a different inbetweenserter approach #6818

Merged
merged 5 commits into from
May 23, 2018
Merged

Try a different inbetweenserter approach #6818

merged 5 commits into from
May 23, 2018

Commits on May 23, 2018

  1. Try a different inbetweenserter approach 

    This is an attempt to redesign the inbetweenserter to be less frustrating. Currently in master it's too easy to invoke it whe
n you don't mean to.

This branch changes that approach. You can still hover between two lines to reveal a line indicator. But you can't click this line. Instead, a new plus button sits at the center of this line, and you have to click that to insert between.

Please give this a spin. Depending on feedback, it needs visual love, and other tweaks. Right now it's definitely a try branch, and needs your thoughts.
    Joen Asmussen committed May 23, 2018
    Configuration menu
    Copy the full SHA
    e061aa4 View commit details
    Browse the repository at this point in the history

  2. Hide inbetween inserter from empty paragraph blocks + css tweaks

    @youknowriad
    youknowriad authored and Joen Asmussen committed May 23, 2018
    Configuration menu
    Copy the full SHA
    806e9ec View commit details
    Browse the repository at this point in the history

  3. Use a labal prop instead of aria-label for the insertion point

    @youknowriad
    youknowriad committed May 23, 2018
    Configuration menu
    Copy the full SHA
    699b2a2 View commit details
    Browse the repository at this point in the history

  4. Make the inserter visible when focused

    @youknowriad
    youknowriad committed May 23, 2018
    Configuration menu
    Copy the full SHA
    6e7d9a2 View commit details
    Browse the repository at this point in the history

  5. Fix e2e tests

    @youknowriad
    youknowriad committed May 23, 2018
    Configuration menu
    Copy the full SHA
    54783ce View commit details
    Browse the repository at this point in the history