Allow blocks to specify that they can't be made reusable #5280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't allow converting any block with `supports.reusable == false` to a reusable block.
noisysocks
added
[Feature] Block API
|
@noisysocks I'm not sure we should add this — see last reply in #4722. Would like to know more about the use cases this would address. |
|
Let's hold off for now, then. Further discussion in #4722 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4722.
Description
Allows blocks to specify that they can't be made reusable by setting
supports.reusableto false.Right now, the Columns (experimental) block is the only core block that we don't support converting into a reusable block. @aduth is working on that over in #5228.
How to test