Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Details block setting field from the experiments page #51372

Merged
merged 1 commit into from
Jun 10, 2023

Conversation

t-hamano
Copy link
Contributor

@t-hamano t-hamano commented Jun 9, 2023

Follow-up on #50030
Related to: #50997

What?

This PR removes Details block setting field from the experiments page.

Why?

The Details block was stabilized in #50997. The setting field has been removed from the Experiments page accordingly.

However, in #50983, the setting appears to have been restored. Perhaps an unintended line change was made due to merge timing.

Testing Instructions

Access the Experiments page and confirm that the setting field for the Details block is not present.

@t-hamano t-hamano added the [Block] Details Affects the Details Block - used to display content which can be shown/hidden label Jun 9, 2023
@t-hamano t-hamano self-assigned this Jun 9, 2023
@ndiego ndiego added the [Type] Enhancement A suggestion for improvement. label Jun 10, 2023
@ndiego ndiego self-requested a review June 10, 2023 14:45
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into this when testing 16.0. Looks good! 🚢

image

@t-hamano
Copy link
Contributor Author

Thanks for the review, @ndiego!

@t-hamano t-hamano merged commit 493d95a into trunk Jun 10, 2023
@t-hamano t-hamano deleted the details/remove-experiment-field branch June 10, 2023 15:11
@t-hamano t-hamano added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Jun 10, 2023
@github-actions github-actions bot added this to the Gutenberg 16.1 milestone Jun 10, 2023
@ndiego ndiego added the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jun 12, 2023
@ndiego ndiego modified the milestones: Gutenberg 16.1, Gutenberg 16.0 Jun 12, 2023
@ndiego ndiego removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jun 12, 2023
@ndiego ndiego modified the milestones: Gutenberg 16.0, Gutenberg 16.1 Jun 12, 2023
@ndiego
Copy link
Member

ndiego commented Jun 12, 2023

I mistakenly thought this needed to be included in 16.0, hence all the label/milestone updates. The Details block setting is in fact, removed from 16.0, so no backport needed. This PR just needs to be included in 16.1. Sorry for any confusion.

sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Details Affects the Details Block - used to display content which can be shown/hidden Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants