Move gutenberg_get_global_styles function
#50596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: lib/compat/wordpress-6.3/get-global-styles-and-settings.php To: lib/global-styles-and-settings.php The reason is that while the global styles APIs continue to be developed we need the plugin classes to be in use by the public API.
oandregal
added
the
Global Styles
This was referenced May 12, 2023
aaronrobertshaw
approved these changes
May 15, 2023
|
This one doesn't need to be backported, as it only moves code around for gutenberg purposes. The relevant changes are included in this other PR to backport #50366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #50310
Related #50597
What
This PR moves
gutenberg_get_global_stylesfrom:lib/compat/wordpress-6.3/get-global-styles-and-settings.phptolib/global-styles-and-settings.phpWhy?
The reason is that while the global styles APIs continue to be developed, we need the public API to use the gutenberg classes.
How?
Move the function from one file to another verbatim.
Testing Instructions
Verify automated test pass.