Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fluid typography: use layout.wideSize as max viewport width #49815

Merged
merged 8 commits into from
May 8, 2023
Merged

Fluid typography: use layout.wideSize as max viewport width #49815

merged 8 commits into from
May 8, 2023

Commits on Apr 20, 2023

  1. Fluid Typography: Try adding a ceiling to the calculated minimum font… 

    … size
    @andrewserong @ramonjd
    andrewserong authored and ramonjd committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    17ef72c View commit details
    Browse the repository at this point in the history

  2. Add test to ensure ceiling is skipped when min font size is provided

    @andrewserong @ramonjd
    andrewserong authored and ramonjd committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    fe86949 View commit details
    Browse the repository at this point in the history

  3. In this commit, we use a logarithmic scale factor to calculate a mini… 

    …mum font scale that tapers out as the font size increases.

The calculation is only performed where there no min font size is passed to the fluid font size methods.
The min font scale factor is constrained by min and max values.
Tests are updated to reflect the new clamp values.
Docs are updated to reflect API change in JS function (removing minimumFontSizeFactor arg)
    @ramonjd
    ramonjd committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6da3969 View commit details
    Browse the repository at this point in the history

  4. Fix lint and JS tests

    @ramonjd
    ramonjd committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    11b68ca View commit details
    Browse the repository at this point in the history

  5. EL LINTO DEL DIABLO!

    @ramonjd
    ramonjd committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    d6dab88 View commit details
    Browse the repository at this point in the history

  6. Based on #49707 

    Testing out using `settings.layout.wideSize` as the maximum viewport width
Updating tests to come
    @ramonjd
    ramonjd committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    3f23a05 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Updating tests and generally cleaning up after a bizarre rebase session.

    @ramonjd
    ramonjd committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    fff98f0 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. This commit: 

    - elaborates on the purpose of layout.wideSize in the theme.json schema
    @ramonjd
    ramonjd committed May 1, 2023
    Configuration menu
    Copy the full SHA
    e029916 View commit details
    Browse the repository at this point in the history