-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try: New Group, Stack, Row block descriptions. #40176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
A suggestion for improvement.
[Type] Copy
Issues or PRs that need copy editing assistance
[Block] Group
Affects the Group Block
labels
Apr 8, 2022
jasmussen
requested review from
ajitbohra,
mkaz,
ryanwelcher and
juanmaguitar
as code owners
April 8, 2022 06:27
Size Change: +110 B (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
aristath
approved these changes
Apr 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
38 tasks
This was referenced Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] Group
Affects the Group Block
[Type] Copy
Issues or PRs that need copy editing assistance
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative to #40062. This PR changes the descriptions of Group, Row and Stack blocks to be a bit more verbose, while still not causing layout shifts in the inspector when switching between them:
Why?
The hope is to use the expanded description to better clarify what the variations are for.
Testing Instructions
Insert a group block, try stack and row variations and observe the descriptions for all 3 variants in the inspector, and the inserter.