Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wp_unique_id() instead of uniqid() in block_core_gallery_render() #39983

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Use wp_unique_id() instead of uniqid() in block_core_gallery_render() #39983

merged 1 commit into from
Apr 3, 2022

Conversation

westonruter
Copy link
Member

This is amends #38164.

Fixes #38889.

Previously #38891.

What?

Why?

How?

Testing Instructions

Screenshots or screencast

@westonruter westonruter requested a review from geriux as a code owner April 1, 2022 17:09
@westonruter westonruter mentioned this pull request Apr 1, 2022
Merged
gziolo
gziolo approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

Do you think it is something we could programmatically enforce in the future?

@gziolo gziolo added [Type] Code Quality Issues or PRs that relate to code quality [Block] Gallery Affects the Gallery Block - used to display groups of images labels Apr 2, 2022
@Mamaduka Mamaduka merged commit 090ec5a into trunk Apr 3, 2022
@Mamaduka Mamaduka deleted the update/unique-id-function-in-gallery-block branch April 3, 2022 07:02
@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Apr 3, 2022
@westonruter
Copy link
Member Author

Do you think it is something we could programmatically enforce in the future?

A custom PHPCS ruleset would do it, although that may be overkill.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@geriux geriux Awaiting requested review from geriux geriux is a code owner

Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
Gutenberg 13.0
Development

Successfully merging this pull request may close these issues.

Use of uniqid() in generated CSS class names breaks ability to cache parsed CSS
3 participants
@westonruter @gziolo @Mamaduka