Theme Export: Use the theme name for the zip file #39471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
the
[Feature] Themes
scruffian
added
the
[Feature] Site Editor
8 tasks
|
Size Change: +87 B (0%) Total Size: 1.21 MB
ℹ️ View Unchanged
|
|
I'm seeing the same thing: Using https://localwp.com/ |
|
I am using Local, PHP version 7.4.1, WordPress 5.9.2. |
|
@MaggieCabrera @jffng thanks for the review. This happens when your theme is loaded in a symlink. I have pushed a commit to fix that... |
wow, looks like a specific edge case then. If it won't break for other people then thank you so much for investigating this! |
I think it's probably quite a common use case, but regardless it shouldn't happen anymore! |
MaggieCabrera
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
This is looking great! I'm approving this since the PR does what it says, but I'm going to highlight what I've encountered while exporting Archeo with some color changes in GS so you can consider them in a follow-up:
The templates that had CSS variables when exporting turn into:
<!-- wp:post-featured-image {"align":"wide","style":{"spacing":{"margin":{"bottom":"var(\u002d\u002dwp\u002d\u002dcustom\u002d\u002dspacing\u002d\u002dsmall, 1.25rem)"}}}} /-->
The theme.json file is missing this from the original theme:
- The schema:
"$schema": "https://schemas.wp.org/trunk/theme.json", "appearanceTools": true,inside settings
scruffian
force-pushed
the
update/theme-export-file-name
branch
from
f79db45
to
62c03ff
Compare
|
Thanks @MaggieCabrera I created issues for these here: |
scruffian
force-pushed
the
update/theme-export-file-name
branch
2 times, most recently
from
76dfc3f
to
ba0436b
Compare
scruffian
force-pushed
the
update/theme-export-file-name
branch
from
ba0436b
to
2cd9c7b
Compare
jostnes
pushed a commit
to jostnes/gutenberg
that referenced
this pull request
Mar 23, 2022
* Theme Export: Use the theme name for the zip file * reformat * don't use the real path * fix linting * update test
36 tasks
bph
added
the
Needs Dev Note
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Use the name of the theme in the zip file for the export.
Why?
This makes it easier to add the theme to your WordPress install
How?
We pass the theme name from the REST endpoint to the JS in the headers.
Testing Instructions