-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update drag handle footprint. #39342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Code Quality
Issues or PRs that relate to code quality
[Package] Icons
/packages/icons
labels
Mar 10, 2022
Size Change: -7 B (0%) Total Size: 1.16 MB
ℹ️ View Unchanged
|
gwwar
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This tests well for me @jasmussen!
Thank you! |
I cherry-picked this PR into Gutenberg 12.8 release to prevent issues with the merge conflicts in the CHANGELOG file while publishing to npm with the automated script. |
gziolo
pushed a commit
that referenced
this pull request
Mar 11, 2022
* Update drag handle footprint. * Wrap changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The
dragHandle
icon is 18x18px. As part of the icon library, it should be 24x24.Why?
The icon library is meant to be in sync with the WordPress Figma Design Library, so it's important it stays in sync.
How?
This PR updates the footprint to match the Figma, and to be 24x24.
Testing Instructions
Check all the instances of the dragHandle icon, most notably by selecting a block and looking at the block toolbar. Before and after should look identical.
Screenshots or screencast
Before, footprint:
After, footprint:
A before and after comparison screenshot:
As it turns out, 24px was already reserved for the drag handle, so changing the footprint of the icon didn't require any CSS changes.