[Block Conversion]: Show group option in Group blocks
#39094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Feature] Block Transforms
ntsekouras
requested review from
mcsf,
youknowriad,
mtias,
kjellr and
jasmussen
|
Size Change: -463 B (0%) Total Size: 1.15 MB
ℹ️ View Unchanged
|
|
Grouping a group. Yes indeed! This seems okay to me. The primary takeaway here, I feel, is that we should see if we could get ⌘G to be a Group shortcut, and ⌘⇧G be an "ungroup" shortcut. Nothing to block anything, just something to think about! |
Unfortunately these are already pretty common web browser shortcuts for Find Next/Find Previous. I think that's why the shortcut hasn't been added yet. |
talldan
approved these changes
Mar 1, 2022
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #39062
This PR adds the
groupoption to Group blocks in block settings menu. I intentionally didn't add the option in the Block Switcher transform options as I think this particular transform should be less prominent, yet available. No strong opinions though 😄