From 5c3ea6c6e198cbc45af15479431aaae0f6d93783 Mon Sep 17 00:00:00 2001 From: George Mamadashvili Date: Wed, 24 Nov 2021 10:58:30 +0400 Subject: [PATCH] Cover: Fix undo trap --- packages/block-library/src/cover/edit.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/block-library/src/cover/edit.js b/packages/block-library/src/cover/edit.js index 5055a6c747cfad..cdab1cfca26e0f 100644 --- a/packages/block-library/src/cover/edit.js +++ b/packages/block-library/src/cover/edit.js @@ -310,6 +310,7 @@ function CoverEdit( { setAttributes, setOverlayColor, toggleSelection, + markNextChangeAsNotPersistent, } ) { const { contentPosition, @@ -391,6 +392,8 @@ function CoverEdit( { ); useEffect( () => { + // This side-effect should not create an undo level. + markNextChangeAsNotPersistent(); setAttributes( { isDark: isCoverDark } ); }, [ isCoverDark ] ); @@ -770,10 +773,14 @@ function CoverEdit( { export default compose( [ withDispatch( ( dispatch ) => { - const { toggleSelection } = dispatch( blockEditorStore ); + const { + toggleSelection, + __unstableMarkNextChangeAsNotPersistent, + } = dispatch( blockEditorStore ); return { toggleSelection, + markNextChangeAsNotPersistent: __unstableMarkNextChangeAsNotPersistent, }; } ), withColors( { overlayColor: 'background-color' } ),