-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update shortcodes to use textarea #3184
update shortcodes to use textarea #3184
Conversation
blocks/library/shortcode/index.js
Outdated
@@ -40,7 +40,7 @@ registerBlockType( 'core/shortcode', { | |||
<Dashicon icon="editor-code" /> | |||
{ __( 'Shortcode' ) } | |||
</label> | |||
<input | |||
<textarea | |||
id={ inputId } | |||
type="text" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<textarea>
has no type attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Thanks!
Per #1709 (comment) maybe this would be better served with a resizable textarea, i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Description
Update shortcode block to use textarea instead of input. #3154
How Has This Been Tested?
Ran tests locally and all is good.
Screenshots (jpeg or gifs if applicable):
Types of changes
Straightforward change of input -> textarea
Checklist: