-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some more g2 icons #21825
Merged
Merged
Add some more g2 icons #21825
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
535ca68
Rename icons, primitives tsconfig to _tsconfig
sirreal ba907b6
Update arrow-left, cog, and help icons
jameskoster 4f25f93
Add "bar chart" icon
jameskoster 5bcf7fb
Add "home" icon
jameskoster 1335181
Add "megaphone" icon
jameskoster 773a579
Add "people" icon
jameskoster 6de7f84
Add "plugin" icon
jameskoster b5fde89
Add "support" icon
jameskoster 4db3d38
Add "tool" icon
jameskoster bc03695
icon definitions
jameskoster fa11410
Merge remote-tracking branch 'upstream/master'
jameskoster f450e4a
Merge branch 'master' into add/more-g2-icons
jameskoster 8f21387
Update "support" icon dimensions and rename to "lifesaver"
jameskoster c1ab69e
Update star icons
jameskoster 1083821
Update star icon dimensions
jameskoster c06adf9
Merge remote-tracking branch 'upstream/master'
jameskoster 21801e2
Merge branch 'master' into add/more-g2-icons
jameskoster bc2e7ef
star-half viewbox
jameskoster 9c5c84d
E2E Tests: Update Plugins snapshots
aduth b8e97f8
Camelcase Path attributes
jameskoster 18deef5
Update "tool" icon
jameskoster e4ce8c4
Update icons package changelog
jameskoster a0e6971
Update packages/icons/package.json
jameskoster 55668b5
Update packages/icons/CHANGELOG.md
jameskoster 2598aa7
Merge branch 'master' into add/more-g2-icons
jameskoster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { SVG, Path } from '@wordpress/primitives'; | ||
|
|
||
| const chartBar = ( | ||
| <SVG xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"> | ||
| <Path | ||
| fillRule="evenodd" | ||
| d="M11.25 5h1.5v15h-1.5V5zM6 10h1.5v10H6V10zm12 4h-1.5v6H18v-6z" | ||
| clipRule="evenodd" | ||
| /> | ||
| </SVG> | ||
| ); | ||
|
|
||
| export default chartBar; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { SVG, Path } from '@wordpress/primitives'; | ||
|
|
||
| const home = ( | ||
| <SVG xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"> | ||
| <Path d="M20 20H4v-9.5L12 4l8 6.5V20zM12 5.933l-6.5 5.281V18.5h13v-7.286L12 5.933z" /> | ||
| </SVG> | ||
| ); | ||
|
|
||
| export default home; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| /** | ||
| * WordPress dependencies | ||
| */ | ||
| import { SVG, Path } from '@wordpress/primitives'; | ||
|
|
||
| const lifesaver = ( | ||
| <SVG xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24"> | ||
| <Path | ||
| fillRule="evenodd" | ||
| d="M17.375 15.656A6.47 6.47 0 0018.5 12a6.47 6.47 0 00-.943-3.374l-1.262.813c.448.749.705 1.625.705 2.561a4.977 4.977 0 01-.887 2.844l1.262.813zm-1.951 1.87l-.813-1.261A4.976 4.976 0 0112 17c-.958 0-1.852-.27-2.613-.736l-.812 1.261A6.47 6.47 0 0012 18.5a6.47 6.47 0 003.424-.974zm-8.8-1.87A6.47 6.47 0 015.5 12c0-1.235.344-2.39.943-3.373l1.261.812A4.977 4.977 0 007 12c0 1.056.328 2.036.887 2.843l-1.262.813zm2.581-7.803A4.977 4.977 0 0112 7c1.035 0 1.996.314 2.794.853l.812-1.262A6.47 6.47 0 0012 5.5a6.47 6.47 0 00-3.607 1.092l.812 1.261zM12 20a8 8 0 100-16 8 8 0 000 16zm0-4.5a3.5 3.5 0 100-7 3.5 3.5 0 000 7z" | ||
| clipRule="evenodd" | ||
| /> | ||
| </SVG> | ||
| ); | ||
|
|
||
| export default lifesaver; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this icon ever published as part of a stable WordPress or Gutenberg release?
If so, we can't simply remove it, since there's a backwards-compatibility commitment.
If it's only ever been published in the plugin, we can deprecate it after two versions.
See:
If it was published in a stable WordPress release, then it must be kept forever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, or is this a unique package in how it's not actually enqueued in the editor? I guess at the very least, if it's only ever intended to be consumed as a package, we'd still want to include a CHANGELOG entry about the removal being a breaking change.
See: https://github.com/WordPress/gutenberg/blob/master/packages/README.md#maintaining-changelogs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added, as an oversight here.
star-filledalready existed (and was identical in it's intended application), sostaris extraneous. Let me know how you think we should proceed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if it isn't exposed directly on the
windowglobal, and it never landed in a published version of the package (verified), then no additional action should be necessary.