Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant (duplicated) reducers #15142

Merged
merged 1 commit into from
May 6, 2019
Merged

Remove redundant (duplicated) reducers #15142

merged 1 commit into from
May 6, 2019

Conversation

ellatrix
Copy link
Member

@ellatrix ellatrix commented Apr 24, 2019 •
edited
Loading

Description

Seems to have been forgotten in #13088 when moving the reducers to a new package.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.

@ellatrix ellatrix added the [Type] Code Quality Issues or PRs that relate to code quality label Apr 24, 2019
@ellatrix ellatrix added the Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code label May 1, 2019
@youknowriad
Copy link
Contributor

I'm pretty sure I removed these :) maybe some merge brought them back :)

@ellatrix
Copy link
Member Author

ellatrix commented May 6, 2019

Thanks @youknowriad. It looks like some, but not all the code was removed.

@ellatrix ellatrix merged commit 06c9f4a into master May 6, 2019
@ellatrix ellatrix deleted the remove/redundant-reducers branch May 6, 2019 15:11
@youknowriad youknowriad added this to the 5.7 (Gutenberg) milestone May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youknowriad youknowriad youknowriad approved these changes

@noisysocks noisysocks Awaiting requested review from noisysocks

@talldan talldan Awaiting requested review from talldan

Assignees
No one assigned
Labels
Good First Review A PR that's suitable for someone looking to contribute for the first time by reviewing code [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
5.7 (Gutenberg)
Development

Successfully merging this pull request may close these issues.
2 participants
@ellatrix @youknowriad