Fix regression with color swatch focus style #14944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you focus a color swatch, the circle around the check is offset. Removing the border that this PR removes, fixes that, and appears to not have any side-effects. I'm not sure how it regressed.
jasmussen
added
the
[Type] Regression
youknowriad
approved these changes
Apr 12, 2019
|
Thank you. Feel free to merge this one in the appropriate milestone when the checks pass. But otherwise, I'd appreciate a sanity check on why this regressed in the first place. @kjellr any idea? |
Yep, the 666eeb9#diff-9863eacb8cd51ff65e89266486cdc139 That does appear necessary for the tooltip to show up, and your fix here doesn't seem to break anything, so I think we're ok. 👍 I'll merge in and assign to 5.5, alongside that patch. |
mchowning
pushed a commit
to mchowning/gutenberg
that referenced
this pull request
Apr 15, 2019
When you focus a color swatch, the circle around the check is offset. Removing the border that this PR removes, fixes that, and appears to not have any side-effects. I'm not sure how it regressed.
aduth
pushed a commit
that referenced
this pull request
Apr 16, 2019
When you focus a color swatch, the circle around the check is offset. Removing the border that this PR removes, fixes that, and appears to not have any side-effects. I'm not sure how it regressed.
aduth
pushed a commit
that referenced
this pull request
Apr 16, 2019
When you focus a color swatch, the circle around the check is offset. Removing the border that this PR removes, fixes that, and appears to not have any side-effects. I'm not sure how it regressed.
This was referenced Apr 17, 2019
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you focus a color swatch, the circle around the check is offset.
Removing the border that this PR removes, fixes that, and appears to not have any side-effects.
I'm not sure how it regressed.
Before:
After: