Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid block 'try recovery' should show block comparison modal #9862

Closed
johngodley opened this issue Sep 13, 2018 · 1 comment
Closed

Invalid block 'try recovery' should show block comparison modal #9862

johngodley opened this issue Sep 13, 2018 · 1 comment
Labels
[Feature] Blocks Overall functionality of blocks

Comments

@johngodley
Copy link
Contributor

johngodley commented Sep 13, 2018 •
edited
Loading

Currently when you trigger an invalid block you get this message:

edit_post_ wordpress_latest _wordpress

The 'try recovery' runs the block through Gutenberg's parsing magic and spits out one or more blocks of the same or different types. This is an opaque experience - the user won't know until they press the button.

Hidden in the ellipsis menu is a 'Compare conversion' option which brings up this comparison modal showing exactly what will happen if 'try recovery' is pressed:

another_post___ wordpress_latest _wordpress

This behaviour should be the default when pressing 'try recovery'.

See #9667 for more details
@johngodley johngodley added the [Feature] Blocks Overall functionality of blocks label Sep 13, 2018
@johngodley johngodley mentioned this issue Sep 13, 2018
Merged
4 tasks
@johngodley
Copy link
Contributor Author

Added in #9667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johngodley