-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shift + Arrow keys (and combinations) should work even with block boundaries faded out #958
Comments
Maybe I'm not understanding it correctly, but you wanted the boundaries to show when text is selected right? |
Yes absolutely! That part is working. The problem is that as I'm writing text, using just the keyboard, every once in a while I'll want to delete a few characters, and I'll hold shift, press left, and delete. Only here, I have to press left twice to select a single character. Try the following in a normal text editor, then in the gutenberg editor, to see the difference:
In the normal text editor, the above will select one character. In gutenberg, currently, it doesn't select anything. You have to press left twice. |
Right it should just skip the invisible character we have there on shift currently we don't override shift/ctrl combinations of selection. This whole feature is all about overriding everything a browser does natively when it comes to selections so I guess there is more cases to handle. |
Just to clarify, I didn't want to suggest this was an issue with the inline boundaries specifically, but rather with the basic text block as a whole in gutenberg. I don't think it's a tinymce issue, actually. |
@jasmussen Is this still an issue? I can't reproduce in master. |
You're right, this seems addressed! Thanks 🎉 |
Steps to reproduce:
Expected result: block boundaries fade in and you select one character leftwards.
Actual result: block boundaries fade in.
It's a bit hard to see in that GIF. Sometimes you do select one character leftwards but that selection is immediately unset.
The text was updated successfully, but these errors were encountered: