Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid block scrim hides block options on mobile #9402

Closed
johngodley opened this issue Aug 28, 2018 · 3 comments
Closed

Invalid block scrim hides block options on mobile #9402

johngodley opened this issue Aug 28, 2018 · 3 comments
Labels
[Feature] Blocks Overall functionality of blocks Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@johngodley
Copy link
Contributor

Describe the bug
If a block becomes invalid and you are viewing on mobile then the grey scrim hides the block options.

edit_post_ wordpress_latest _wordpress

To Reproduce
Steps to reproduce the behavior:

  1. View editor using a mobile-sized display (i.e. Chrome dev tools > Device)
  2. Make a block invalid (remove the trailing </p> of a paragraph)
  3. Scroll down to the bottom of the block
  4. Note that the block dropdown menu, and other buttons, are hidden behind the grey scrim

Expected behavior
The dropdown menu button to be available as it is on desktop. I'm not sure about the other buttons

@johngodley johngodley added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) labels Aug 28, 2018
@johngodley
Copy link
Contributor Author

@jasmussen pinging for thoughts. I'm happy to try and fix this, but I'm not sure what it should do - should the scrim stop before the bottom toolbar?

@jasmussen
Copy link
Contributor

should the scrim stop before the bottom toolbar?

Yes, that seems like a good solution.

Could we simply do something like .. and this is pseudo code:

.scrim {
	...
	bottom: $block-toolbar-height;

	@include break-small() {
		bottom: 0;
	}
}

☝️ this should make the scrim not cover the bottom toolbar, until the break-small breakpoint where if I recall correctly, the block toolbar moves.

@johngodley
Copy link
Contributor Author

Perfect! Used in a fix in #9473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants