Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table block: Row/Column selection color isn't from the WordPress palette. #8404

Closed
kjellr opened this issue Aug 2, 2018 · 2 comments
Closed
Labels
[Block] Table Affects the Table Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Aug 2, 2018

Describe the bug

When you drag your mouse over a row or column in the table block, that row/column gets highlighted in #2276d2. This color appears to be from a TinyMCE stylesheet, and doesn't match any color I can find in Gutenberg or in the WordPress color palette.

table-select

I'd suggest we swap that out for a tint of Medium Blue (maybe the 40% or 60% version). This would likely improve the text contrast there as well.

To reproduce

  1. Add a table block
  2. Click and drag your mouse across a row or column
  3. Take note of the highlight color.
@kjellr kjellr added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Aug 2, 2018
@kjellr kjellr mentioned this issue Aug 2, 2018
8 tasks
@talldan
Copy link
Contributor

talldan commented Sep 6, 2018

I think this is no longer an issue since the table block rewrite because It doesn't seem possible to select multiple cells at all.

I'll probably repurpose this issue for adding that feature, and will make sure the selection color is correct.

@sarahmonster sarahmonster added the [Block] Table Affects the Table Block label Oct 24, 2018
@mtias mtias added [Type] Enhancement A suggestion for improvement. and removed [Type] Bug An existing feature does not function as intended labels Oct 27, 2018
@talldan
Copy link
Contributor

talldan commented Jul 19, 2019

Closing this in favour of #16294.

@talldan talldan closed this as completed Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants