Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Improve the way styles built for packages are consumed #8067

Closed
gziolo opened this issue Jul 20, 2018 · 1 comment
Closed

Build: Improve the way styles built for packages are consumed #8067

gziolo opened this issue Jul 20, 2018 · 1 comment
Labels
npm Packages Related to npm packages [Type] Build Tooling Issues or PRs related to build tooling [Type] Code Quality Issues or PRs that relate to code quality

Comments

@gziolo
Copy link
Member

gziolo commented Jul 20, 2018

Related issue: #3955.
Related PRs: #7640, #8016.

When working on moving all WordPress modules to packages folder to make them publishable to npm (#3955) we took a shortcut by leaving the old Webpack flow which allows us to consume the existing .scss files in the process. We need to replace it with a revisited approach which will take into account the following:

  • There are no longer folders in the root directory like nux or components.
  • npm run build:packages generates not only CSS files for the package in build-style folder but also their RTL versions.
  • Webpack is able to find them and include in the flow, it might be copied or even better included in the chain of processing.
@gziolo gziolo added [Type] Build Tooling Issues or PRs related to build tooling [Type] Code Quality Issues or PRs that relate to code quality npm Packages Related to npm packages labels Jul 20, 2018
@gziolo gziolo mentioned this issue Jul 20, 2018
Merged
@gziolo
Copy link
Member Author

gziolo commented Jul 30, 2018

Fixed by @youknowriad in #8187 🎉

@gziolo gziolo closed this as completed Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
npm Packages Related to npm packages [Type] Build Tooling Issues or PRs related to build tooling [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gziolo