Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Characters map does not seem to support TinyMCE charmap_append setting #7942

Closed
mrwweb opened this issue Jul 12, 2018 · 4 comments
Closed
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Block] Classic Affects the Classic Editor Block [Feature] Extensibility The ability to extend blocks or the editing experience [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.

Comments

@mrwweb
Copy link

mrwweb commented Jul 12, 2018

Describe the bug
This is a TinyMCE regression from latest WordPress (currently 4.9.7).

As described on #34371 on trac, TinyMCE supports a charmap_append setting to extend the Character Map characters. Here is an example of the code required to add characters. It does not appear to work in Gutenberg (which includes the Character Map in the Classic Editor block).

To Reproduce
Steps to reproduce the behavior:

  1. Install the Hawaiian Characters plugin which extends the character map
  2. Insert a "Classic Editor" block
  3. Open the Character Map

Expected behavior
The added characters are available in the character map palette. At present, they are missing.

Disabling Gutenberg and viewing the character map shows the expected characters.

Screenshots
Current Default Editor:
image

Gutenberg:
image

Desktop:

  • Win10
  • Firefox 61.0.1
  • WordPress 4.9.7
  • Gutenberg 3.2
@designsimply designsimply added [Component] TinyMCE [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes. labels Jul 18, 2018
@danielbachhuber danielbachhuber added Backwards Compatibility Issues or PRs that impact backwards compatability [Type] Bug An existing feature does not function as intended labels Jul 27, 2018
@danielbachhuber
Copy link
Member

I took a quick debug of this issue. Your settings are being passed through to TinyMCE:

[27-Jul-2018 14:41:12 UTC] array (
  'plugins' => 'charmap,colorpicker,hr,lists,media,paste,tabfocus,textcolor,fullscreen,wordpress,wpautoresize,wpeditimage,wpemoji,wpgallery,wplink,wpdialogs,wptextpattern,wpview',
  'toolbar1' => 'formatselect,bold,italic,bullist,numlist,blockquote,alignleft,aligncenter,alignright,link,unlink,wp_more,spellchecker,kitchensink',
  'toolbar2' => 'strikethrough,hr,forecolor,pastetext,removeformat,charmap,outdent,indent,undo,redo,wp_help',
  'toolbar3' => '',
  'toolbar4' => '',
  'external_plugins' => 
  array (
  ),
  'charmap_append' => '[["0256","A - kahako"],["0257","a - kahako"],["0274","E - kahako"],["0275","e - kahako"],["0298","I - kahako"],["0299","i - kahako"],["0332","O - kahako"],["0333","o - kahako"],["0362","U - kahako"],["0363","u - kahako"],["0699","okina"]]',
)

Maybe this is a bug with TinyMCE?

@mtias mtias removed this from the Merge: Back Compat milestone Oct 3, 2018
@mtias mtias added the [Feature] Extensibility The ability to extend blocks or the editing experience label Oct 3, 2018
@mtias mtias added this to the WordPress 5.0 milestone Oct 3, 2018
@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Oct 26, 2018
@danielbachhuber
Copy link
Member

@mrwweb Can you test #10968 to verify the fix?

@ellatrix ellatrix added [Block] Classic Affects the Classic Editor Block and removed [External Package] TinyMCE labels Oct 31, 2018
@mtias mtias added the [Status] In Progress Tracking issues with work in progress label Nov 15, 2018
@youknowriad
Copy link
Contributor

closed by #10968

@mrwweb
Copy link
Author

mrwweb commented Nov 21, 2018

Sorry for not getting to this sooner, @danielbachhuber, but it does seem to be working as of beta5!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Block] Classic Affects the Classic Editor Block [Feature] Extensibility The ability to extend blocks or the editing experience [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Plugin Interoperability Incompatibilities between a specific plugin and the block editor. Close with workaround notes.
Projects
None yet
Development

No branches or pull requests

6 participants