Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classic Block toolbar doesn't sit on the edge of frame #7918

Closed
maddisondesigns opened this issue Jul 12, 2018 · 2 comments · Fixed by #8314
Closed

Classic Block toolbar doesn't sit on the edge of frame #7918

maddisondesigns opened this issue Jul 12, 2018 · 2 comments · Fixed by #8314
Labels
[Feature] Blocks Overall functionality of blocks [Feature] UI Components Impacts or related to the UI component system Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Milestone
3.5

Comments

@maddisondesigns
Copy link

Describe the bug
The toolbar on the Classic Block no longer sits right on the top edge of the block, like it used to. There's now a weird gap appearing above the toolbar.

screenshot_731

To Reproduce
Steps to reproduce the behavior:

  1. Add Classic Block
  2. Take note of toolbar location in reference to block container

Expected behavior
Toolbar should align with the top edge of the Block.

macOS Sierra 10.12.1
Firefox Quantum 61.0.1 (64-bit)
Gutenberg 3.2.0
@maddisondesigns maddisondesigns changed the title Classic Block toolbard doesn't sit on the edge of frame Classic Block toolbar doesn't sit on the edge of frame Jul 12, 2018
@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks [Feature] UI Components Impacts or related to the UI component system labels Jul 16, 2018
@designsimply
Copy link
Member

Tested and confirmed using WordPress 4.9.7 and Gutenberg 3.2.0 on Firefox 61.0.1 on macOS 10.13.5.

screen shot 2018-07-16 at mon jul 16 1 07 54 pm

@designsimply designsimply added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jul 16, 2018
@aduth
Copy link
Member

aduth commented Jul 17, 2018

Duplicate of #7728. Since this has more context, I'll close the other.

This was referenced Jul 17, 2018
Closed
Closed
@mcsf mcsf added this to the 3.4 milestone Jul 20, 2018
@pento pento modified the milestones: 3.4, 3.5 Jul 30, 2018
@aduth aduth mentioned this issue Jul 30, 2018
Closed
@jasmussen jasmussen mentioned this issue Jul 31, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Blocks Overall functionality of blocks [Feature] UI Components Impacts or related to the UI component system Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.5
5 participants
@mcsf @pento @designsimply @aduth @maddisondesigns