Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sibling inserter doesn't appear above selected block with no toolbar #7884

Closed
noisysocks opened this issue Jul 11, 2018 · 4 comments
Closed
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

noisysocks commented Jul 11, 2018

Describe the bug
The sibling inserter (+) doesn't appear above a block that is selected if the block has no toolbar.

To Reproduce

  1. Insert a paragraph block with text
  2. Insert a More block
  3. With the More block selected, hover your mouse over in the centre area between the Paragraph block and the More block
  4. Notice that sibling inserter doesn't appear.

Expected behavior
The sibling inserter (+) should appear.

Screenshots
inserter

Additional context
This is because we disable :hover on the sibling inserter that is before a selected block. This prevents it from getting in the way when there is a toolbar.

.is-selected > .editor-block-list__insertion-point > .editor-block-list__insertion-point-inserter {
opacity: 0;
pointer-events: none;
&:hover,
&.is-visible {
opacity: 1;
pointer-events: auto;
}
}

To fix this, we would have to update the CSS above to be smart enough to know whether or not there are items in BlockToolbar. This could be awkward since that information is stored in React context.

Came up in #7799.

@noisysocks noisysocks added [Type] Bug An existing feature does not function as intended [Feature] Inserter The main way to insert blocks using the + button in the editing interface labels Jul 11, 2018
@noisysocks
Copy link
Member Author

Not sure how much of a priority this is.

@jasmussen @karmatosed – would you mind putting it in a milestone if you think it's worth doing or just closing it if not?

@karmatosed
Copy link
Member

I think this could annoy some people so let's milestone it.

@mtias
Copy link
Member

mtias commented Oct 23, 2018

This seems to be working as expected now.

@mtias mtias closed this as completed Oct 23, 2018
@ZebulanStanphill
Copy link
Member

@mtias Since all blocks have toolbars now due to the ellipsis menu being moved there, the original intent of this ticket doesn't really make sense anymore. There are no blocks without toolbars. So yeah, it is working as expected, but what the issue wanted to accomplish has not been done, though it is now not really feasible anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants