Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No way to abort making a link #778

Closed
notnownikki opened this issue May 12, 2017 · 0 comments
Closed

No way to abort making a link #778

notnownikki opened this issue May 12, 2017 · 0 comments
Assignees
@mkaz
Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Milestone
Beta 2

Comments

@notnownikki
Copy link
Member

If you select some text and click the link icon on the toolbar, there's no way to abort. If you click outside of the url input, the text is a link with no href, you have to click it again to get the control to remove the link.

I think it makes sense to have a cancel button on the url input, and it would be nice if pressing escape canceled too.
@mtias mtias added [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended labels May 15, 2017
@jasmussen jasmussen added this to the Beta milestone May 16, 2017
@aduth aduth added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label May 26, 2017
@mkaz mkaz self-assigned this Jun 12, 2017
@mkaz mkaz mentioned this issue Jun 12, 2017
Merged
@mtias mtias modified the milestones: Beta 2, Beta Jun 15, 2017
@yaseenaljamal yaseenaljamal mentioned this issue Sep 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkaz mkaz

Labels
[Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Beta 2
Development

No branches or pull requests
5 participants
@mkaz @mtias @jasmussen @aduth @notnownikki