Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child block side UI doesn't reposition in align-wide/full #7646

Closed
chrisvanpatten opened this issue Jun 30, 2018 · 3 comments · Fixed by #19344
Closed

Child block side UI doesn't reposition in align-wide/full #7646

chrisvanpatten opened this issue Jun 30, 2018 · 3 comments · Fixed by #19344
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Milestone

Comments

@chrisvanpatten
Copy link
Contributor

chrisvanpatten commented Jun 30, 2018

When a block is aligned wide or full, side UI controls are repositioned above the block to ensure the controls are accessible.

untitled____add_new_page mindful _wordpress

However, this does not apply to child blocks where the parent is aligned wide or full, causing the child's side UI controls to become unavailable:

untitled____add_new_page mindful _wordpress_and_typinator

(This would be solved by #6224.)

To Reproduce
Steps to reproduce the behavior:

  1. Create a block that can be aligned wide or full, with an InnerBlocks component
  2. Set the block alignment to full
  3. Insert a child block
  4. Note that you can't access the side UI controls

Expected behavior
Side UI controls should be accessible regardless of the block's alignment settings.

@designsimply
Copy link
Member

designsimply commented Jul 3, 2018

I would like to help test this. Could you let me know an example core block which can be aligned wide or full that also has child blocks or perhaps provide an example to use for testing purposes?

@designsimply designsimply added [Type] Bug An existing feature does not function as intended [Feature] UI Components Impacts or related to the UI component system General Interface Parts of the UI which don't fall neatly under other labels. and removed [Feature] UI Components Impacts or related to the UI component system labels Jul 3, 2018
@chrisvanpatten
Copy link
Contributor Author

@designsimply Sorry I missed your reply! At the moment, I don't believe any core blocks exhibit this behaviour. However, I think this will also be solved by #6224. I'd like to leave this open for now, but if it looks like #6224 is on the right path to land in Gutenberg (it's still a bit too soon to say), it'd be a good candidate for closure.

@chrisvanpatten
Copy link
Contributor Author

This is still an issue although now only on the left side. I'm not sure I have a good idea on fixing this short of repositioning the movers entirely, but that's a bigger chat.

@mtias mtias added this to the Future: 5.1 milestone Nov 12, 2018
@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Nov 12, 2018
@youknowriad youknowriad mentioned this issue Jan 16, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants