-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot edit navigation settings or styles when editing navigation specifically #69101
Comments
As far as I know, this is intentional. |
Yes as carolinan says it's not a bug. This allows the menu to be re-used elsewhere in a navigation block. For example using the same menu in header and footer where you may need it to be styled differently. If the styling was directly on the menu, then everywhere that menu was used would inherit identical styling. As an analogy, a post title does not have styling/color/font size applied directly, allowing the post title to be displayed where it is required but with different styling based on where it is being displayed and in what context. |
Even if this is how it works, it is unclear to many users, it is not easy to understand the differences. |
I agree it is unclear and I must admit that I was initially confused when Navigation first appeared in the site editor sidebar. How could it be made clearer and easier to understand the differences? Going back to classic theming, menu management was named "Menus" and there was no mention of the word navigation. Now in block theming we have the "Navigation" block, and the menu management panel is also named "Navigation" in the site editor sidebar. |
If it was actually implemented that way, I could see it. But it is possible to edit everything of the child blocks of the navigation menu, including styles. So if it's indeed intended to only edit the contents of the menu, I'd say it's still a half baked implementation that would need to be fixed, as it's neither clear nor consistent. Personally, I don't see why we would want to not allow changing how the navigation menu behaves, i.e. the navigation block's settings and styles. But if y'all think it makes more sense to only allow editing the navigation menu content via this view, we should make sure it's consistent, i.e. users shouldn't be able to edit the child blocks' settings and styles either, only the contents. |
I'm not sure I understand what you mean. The block tab refers to "Navigation", which is the user-facing name of the navigation block. It's not referring to an inner block, other than listing them below. It is possible to select the overall navigation block via this view, which is arguably pointless if this view should only allow editing the contents of the navigation menu. |
Description
When editing the navigation of the site specifically in the Site Editor, the navigation block's settings and styles cannot be modified. This is confusing because this UI literally exists to edit the navigation, but a key part of doing so is not accessible via the UI.
Users currently need to edit the navigation as part of a template or template part to have the navigation block settings and styles available. This can lead to a user not even being aware of these options because, if they want to edit the navigation specifically, they'll likely open the UI that is purely focused on the navigation (which of course also helps focus by avoiding the "clutter" of other blocks on the page).
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
Environment info
This bug has nothing to do with the environment, it happens consistently.
Please confirm that you have searched existing issues in the repo.
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Please confirm which theme type you used for testing.
The text was updated successfully, but these errors were encountered: