Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Grid Column Width Exceeding Container (Grid interactivity) #69059

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Prevent Grid Column Width Exceeding Container (Grid interactivity) #69059

wants to merge 1 commit into from
+1 −1

Conversation

huubl
Copy link
Contributor

@huubl huubl commented Feb 5, 2025 •
edited
Loading

What?

Closes #69060

Updates the $max_value calculation in the gutenberg_get_layout_style function to prevent columns from exceeding the container's width. Adds a min function to ensure minimumColumnWidth does not surpass 100% of the container's available space.

Why?

This PR is necessary to fix layout issues where columns could become wider than their container, especially on smaller viewports. This ensures a responsive and consistent layout.

How?

The PR modifies the $max_value calculation in the gutenberg_get_layout_style function by adding a min function to limit the minimumColumnWidth to a maximum of 100% of the container's available space.

Testing Instructions

  1. Create a Playground: https://playground.wordpress.net/?networking=yes&plugin=gutenberg
  2. Enable "Blocks: add Grid interactivity" in the Experimental settings
  3. Add this to a page:
<!-- wp:group {"align":"full","layout":{"type":"grid","columnCount":2,"minimumColumnWidth":"793px"}} -->
<div class="wp-block-group alignfull"><!-- wp:group {"style":{"color":{"background":"#ff0000"},"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30","left":"20px","right":"20px"}}},"layout":{"type":"default"}} -->
<div class="wp-block-group has-background" style="background-color:#ff0000;padding-top:var(--wp--preset--spacing--30);padding-right:20px;padding-bottom:var(--wp--preset--spacing--30);padding-left:20px"><!-- wp:paragraph -->
<p>On mobile this column gets wider than its container</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group -->

<!-- wp:group {"style":{"color":{"background":"#ff0000"},"spacing":{"padding":{"top":"var:preset|spacing|30","bottom":"var:preset|spacing|30","left":"20px","right":"20px"}}},"layout":{"type":"default"}} -->
<div class="wp-block-group has-background" style="background-color:#ff0000;padding-top:var(--wp--preset--spacing--30);padding-right:20px;padding-bottom:var(--wp--preset--spacing--30);padding-left:20px"><!-- wp:paragraph -->
<p>On mobile this column gets wider than its container</p>
<!-- /wp:paragraph --></div>
<!-- /wp:group --></div>
<!-- /wp:group -->
  1. Check frontend at 400px viewport and confirm the columns are exceeding the viewport/grid container.

Testing Instructions for Keyboard

--

Screenshots or screencast

Before After
image image

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: huubl <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@huubl huubl mentioned this pull request Feb 5, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellthemachines tellthemachines Awaiting requested review from tellthemachines tellthemachines is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grid Column Width Exceeding Container on mobile (Grid interactivity)
1 participant
@huubl