Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum number of nested column blocks? #6593

Closed
stevejburge opened this issue May 4, 2018 · 8 comments
Closed

Maximum number of nested column blocks? #6593

stevejburge opened this issue May 4, 2018 · 8 comments
Labels
[Feature] Block API API that allows to express the block paradigm.
Milestone

Comments

@stevejburge
Copy link

It feels like there should be a maximum number of column blocks.

At the moment you can have column blocks under column blocks under column blocks. This is what happens when you get 3 levels deep (so the page is divided into 8)

overlays

I tried doing a 4th row under that and the overlay elements really started to get crossed-up

screen shot 2018-05-04 at 10 58 58 am

Visually, it seems hard to image how the Gutenberg interface could be kept straight beyond the 2nd or perhaps 3rd level.

@ZebulanStanphill
Copy link
Member

Possibly a duplicate of #5961, though that issue was made back when the nested block UI/UX was a lot worse than it is now.

And speaking of which, I am not sure it is worth considering an arbitrary limit on how many Columns blocks can be nested, since the UI can still be improved, and it is possible that the Columns block will end up being replaced by a more flexible Layout block (see #5351 (comment)) that would reduce the need for nesting, so situations like this would be less likely to occur.

There is also the work going on in #6471 and the try/alternate-hover-approach branch, which should also help with the UI/UX around nested blocks.

It should also be noted that the content width of the Gutenberg editor can be changed by the theme to match the front-end, and so in some cases the width of the editor will be wide enough to allow for more nesting without things getting crowded. Because of this, it seems weird to implement an arbitrary restriction on how many levels of nesting you can have.

@stevejburge
Copy link
Author

stevejburge commented May 9, 2018

Thanks @SuperGeniusZeb.

Yes, point taken. I'm not quite sure of the best approach here. I'll do some more testing.

Still, there's definitely a point at which things go very funky here. Add enough column blocks and the UI quickly becomes unworkable.

@danielbachhuber danielbachhuber added the [Feature] Block API API that allows to express the block paradigm. label May 16, 2018
@danielbachhuber danielbachhuber added this to the Merge Proposal: Editor milestone May 16, 2018
@danielbachhuber
Copy link
Member

Filing against Merge Proposal: Editor because I feel like we need a yes / no decision against this:

It feels like there should be a maximum number of column blocks.

@mtias
Copy link
Member

mtias commented Jun 22, 2018

There'll be a maximum set by virtue of the slider.

image

What that is in final form remains to be seen.

@mtias mtias closed this as completed Jun 22, 2018
@ZebulanStanphill
Copy link
Member

@mtias That is not what this issue was about. It was suggesting that there be a limit to how many levels of Columns blocks can be nested in each other.

Personally, I see no reason to limit the amount of nesting, since overly deep nesting would usually only occur in cases where the user is messing around and not seriously building a layout, and since the point where nested block UI becomes hard to use varies depending on the editor width set by the theme and the viewport width. Additionally, recent improvements have done a lot to make the UI/UX in nested contexts less confusing, so I think this is already less of a problem than when this issue was created.

@mtias
Copy link
Member

mtias commented Jun 22, 2018

Ah, sure, I don't think we should be restricting nesting levels.

@stevejburge
Copy link
Author

stevejburge commented Jun 22, 2018

Following up on my original bug-report ... the problem seems fixed. I've been trying without success to create the issue on the latest Gutenberg release.

To be honest, I don't think people could do it if it was possible. The UI breaks down by the time you get to adding a 3rd nested column block:

screen shot 2018-06-22 at 12 10 00 pm

@mrpritchett
Copy link

At the fifth level of nested column, the UI is 100% on top of the next column over. So unless we think people are magic, we should be fixing this issue or restricting the level to which blocks can be nested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm.
Projects
None yet
Development

No branches or pull requests

5 participants