Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "Edit" control from the zoom out toolbar #65746

Closed
richtabor opened this issue Sep 30, 2024 · 6 comments · Fixed by #65760
Closed

Remove the "Edit" control from the zoom out toolbar #65746

richtabor opened this issue Sep 30, 2024 · 6 comments · Fixed by #65760
Assignees
Labels
[Feature] Zoom Out [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Sep 30, 2024

I propose we revert the recently added "Edit" button to the zoom out toolbar:

  1. With Edit Mode: Prevent editable text selection on first click #65702 incoming, there's less of a need for an additional shortcut to edit the pattern, as you click on a pattern to access its editable blocks.
  2. The "Edit" action and icon do not map to the edit/writing tool in the editor header, as they are presented the same but have quite different results (this just zooms you back in). Related Update write/design tools panel items  #65663.
  3. It's much clearer now how to disengage zoom out, with the addition of the toggle in the editor header.
  4. Double-click also exists as a mechanism to disengage zoom out.

CleanShot 2024-09-30 at 10 29 42

@richtabor richtabor added [Type] Enhancement A suggestion for improvement. [Feature] Zoom Out labels Sep 30, 2024
@jeryj
Copy link
Contributor

jeryj commented Sep 30, 2024

A big rationale for adding the Edit button was to allow keyboard users the same affordance as the double click to easily enter the full editing experience while keeping the same selection. It will be much more annoying for keyboard users to exit zoom out mode to edit the canvas if we remove this edit button. Could we rename the button to something clearer now that “Edit” isn’t fully accurate?

I don’t think we should using arguments for removing this button that include clicking as the alternative, as the edit button is an affordance to make it easier for keyboard users.

@richtabor
Copy link
Member Author

I don’t think we should using arguments for removing this button that include clicking as the alternative, as the edit button is an affordance to make it easier for keyboard users.

What keyboard-centric affordances can we have in place to exit zoom out?

@jeryj
Copy link
Contributor

jeryj commented Sep 30, 2024

I think something that makes it as easy as the double click on the section. If we don't want a toolbar button, maybe pressing Enter while focus is on the section? I'm not sure if that's a good idea or not.

@jeryj
Copy link
Contributor

jeryj commented Sep 30, 2024

I just tried pressing Enter while on block selection to see what happens... It adds a new empty paragraph block 😅 I don't think that was the intended behavior, so why don't we try that as an affordance for exiting zoom out and see how it feels? Also, given that no one has removed this behavior yet, hopefully it won't interrupt anyone's flow.

Screen.Recording.2024-09-30.at.2.35.09.PM.mov

@richtabor
Copy link
Member Author

I just tried pressing Enter while on block selection to see what happens... It adds a new empty paragraph block 😅 I don't think that was the intended behavior, so why don't we try that as an affordance for exiting zoom out and see how it feels? Also, given that no one has removed this behavior yet, hopefully it won't interrupt anyone's flow.

That's interesting. There's potential there.

Let's just make sure it works well with #65702, as that will be the standard zoom out experience.

@getdave
Copy link
Contributor

getdave commented Oct 1, 2024

Just noting that I don't believe this is going to be targetted for 6.7 so I think we can remove from the board 🙇

@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.7 Editor Tasks Oct 4, 2024
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Zoom Out [Type] Enhancement A suggestion for improvement.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants