-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the "Edit" control from the zoom out toolbar #65746
Comments
A big rationale for adding the Edit button was to allow keyboard users the same affordance as the double click to easily enter the full editing experience while keeping the same selection. It will be much more annoying for keyboard users to exit zoom out mode to edit the canvas if we remove this edit button. Could we rename the button to something clearer now that “Edit” isn’t fully accurate? I don’t think we should using arguments for removing this button that include clicking as the alternative, as the edit button is an affordance to make it easier for keyboard users. |
What keyboard-centric affordances can we have in place to exit zoom out? |
I think something that makes it as easy as the double click on the section. If we don't want a toolbar button, maybe pressing Enter while focus is on the section? I'm not sure if that's a good idea or not. |
I just tried pressing Enter while on block selection to see what happens... It adds a new empty paragraph block 😅 I don't think that was the intended behavior, so why don't we try that as an affordance for exiting zoom out and see how it feels? Also, given that no one has removed this behavior yet, hopefully it won't interrupt anyone's flow. Screen.Recording.2024-09-30.at.2.35.09.PM.mov |
That's interesting. There's potential there. Let's just make sure it works well with #65702, as that will be the standard zoom out experience. |
Just noting that I don't believe this is going to be targetted for 6.7 so I think we can remove from the board 🙇 |
I propose we revert the recently added "Edit" button to the zoom out toolbar:
The text was updated successfully, but these errors were encountered: