Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigational dead end on smaller viewports #62878

Closed
jameskoster opened this issue Jun 26, 2024 · 7 comments
Closed

Navigational dead end on smaller viewports #62878

jameskoster opened this issue Jun 26, 2024 · 7 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Jun 26, 2024

On smaller viewports, once you navigate into a data view in the Site Editor (e.g. Pages or Patterns), you end up stuck in that view. There's no way to return to the main navigation, or (in the case of Patterns & Templates) open the Editor.

trap.mp4

Related: #60847.

@jameskoster jameskoster added [Type] Bug An existing feature does not function as intended Mobile Web Viewport sizes for mobile and tablet devices [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 26, 2024
@youknowriad
Copy link
Contributor

I think there's two issues here:

  • Not having the ability to return to previous pages: I think this is arguable because you can always click back in your browser but I agree that it's inconsistent with desktop and we might want to bring a navigation bar/breadcrumb on top.

  • The fact that you can't navigate to the editor is the most concerning one and would love to have it fixed for 6.6. So I'm temptatively adding this issue to 6.6 for this issue.

@jameskoster
Copy link
Contributor Author

I think this is arguable because you can always click back in your browser

True, but that will not work well in the following common flow: Open site editor → Pages → Select page → Edit → Click (W) Button → Click browser back button.

In this case the back button would return you to the Editor.

@t-hamano
Copy link
Contributor

Perhaps it's related to #62106 as well?

@ramonjd
Copy link
Member

ramonjd commented Jul 2, 2024

Not having the ability to return to previous pages: I think this is arguable because you can always click back in your browser but I agree that it's inconsistent with desktop and we might want to bring a navigation bar/breadcrumb on top.

You can use the browser's back button and it will take you back, but only back to where you came from. 😄

So if you click into Templates, and then to the Editor (you'll need #63002), and then back to Templates, clicking the browser's back button will take you back to the Editor.

Kapture.2024-07-02.at.12.44.05.mp4

It would useful to be able to navigation back to the Design menu directly.

I didn't have a lot of time, but I hacked together a very quick workaround for this.

Kapture.2024-07-02.at.12.29.47.mp4

The fact that you can't navigate to the editor is the most concerning one and would love to have it fixed for 6.6. So I'm temptatively adding this issue to 6.6 for this issue.

Agree, this one is the blocker. Looking at a fix over in #63002

@oandregal
Copy link
Member

I've prepared #63060 as a potential quick change for 6.6.

@youknowriad
Copy link
Contributor

This seems fixed right, can we close it?

@t-hamano
Copy link
Contributor

t-hamano commented Jul 9, 2024

I think we can close this issue too. If other issues arise, I'm sure we can address them in a new issue.

@t-hamano t-hamano closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

No branches or pull requests

5 participants