Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern Overrides: Unable to set some attributes like Image block Aspect Ratio when editing the original pattern #62814

Closed
talldan opened this issue Jun 25, 2024 · 1 comment · Fixed by #62828
Assignees
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jun 25, 2024

Description

When editing the original pattern and the block has overrides active, some attributes like 'aspect ratio' don't work.

This is a side effect of #62471, which disabled regular attribute updates for any block with a __default pattern override binding. The intention of that PR was to only affect pattern instances to stop situations where edits could be applied to 'locked' parts of blocks. However, it also affects the block when editing the original pattern.

I think it may be worth reverting that PR, even though reverting will cause two new issues:

Step-by-step reproduction instructions

  1. Create a pattern
  2. Add an image block
  3. Enable bindings for the image block
  4. Upload an image to the block
  5. Try adjusting Aspect Ratio, observe it doesn't work.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@talldan talldan added the [Type] Bug An existing feature does not function as intended label Jun 25, 2024
@talldan talldan added the [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) label Jun 25, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 25, 2024
@SantosGuillamot
Copy link
Contributor

I have started this pull request trying to solve the issue.

@annezazu annezazu moved this to 🏗️ In Progress in WordPress 6.6 Editor Tasks Jun 25, 2024
@talldan talldan moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 6.6 Editor Tasks Jun 27, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.6 Editor Tasks Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants