Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom-out mode issues on Safari #60601

Closed
youknowriad opened this issue Apr 9, 2024 · 3 comments
Closed

Zoom-out mode issues on Safari #60601

youknowriad opened this issue Apr 9, 2024 · 3 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended

Comments

@youknowriad
Copy link
Contributor

youknowriad commented Apr 9, 2024

Description

On Safari, I can see a number of issues in zoom-out mode.

Opening the zoom-out mode (either though global styles variations or patterns inserter), shows a white background instead of the gray one.

Screenshot 2024-04-09 at 2 00 32 PM

Also, if you open both the global styles and the patterns inserter at the same time, you may see a bit of both.

Screenshot 2024-04-09 at 1 43 36 PM

The third issue is that sometimes I see a huge padding on top of the canvas and I have to scroll down to actually see the template

Screenshot 2024-04-09 at 2 01 51 PM
@youknowriad youknowriad added [Type] Bug An existing feature does not function as intended Browser Issues Issues or PRs that are related to browser specific problems labels Apr 9, 2024
@richtabor
Copy link
Member

Related? #60550

@glendaviesnz
Copy link
Contributor

Opening the zoom-out mode (either though global styles variations or patterns inserter), shows a white background instead of the gray one.

In my investigation into this here, it appears that this is due to the different way in which Safari deals with background color on a transformed element. It seems that Safari does what you would expect and only applies the background to the transformed size of the div, whereas Chrome keeps the background color applied to the pre transformed size of the div. I think it sort if works in Chrome by accident so we probably need to add an additional is-zoomed-out class on the relevant div so we can explicitly apply the background color for this - but that was just a quick assessment, I may be wrong about this.

The third issue is that sometimes I see a huge padding on top of the canvas and I have to scroll down to actually see the template

This should be fixed by this revert.

@MaggieCabrera
Copy link
Contributor

#60873 fixes the first issue, I don't think the second is relevant anymore (we can't have GS sidebar open at the same time as the patterns) and I can't reproduce the third anymore, so if my PR gets merged that should solve this whole issue unless I'm missing something in my testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Type] Bug An existing feature does not function as intended
Projects
Development

No branches or pull requests

4 participants