Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in Padding Application: Global Styles Applied to <td> vs <figure> Tag in Block Editor #59439

Open
Tracked by #32400
faisal-alvi opened this issue Feb 28, 2024 · 1 comment
Labels
[Block] Table Affects the Table Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended

Comments

@faisal-alvi
Copy link
Contributor

faisal-alvi commented Feb 28, 2024

Description

While working on #55047, it was observed that the padding from the Global styles is applied to the individual <td>s, but in the block editor, it is applied to the <figure> tag, even after using the new Selectors API. This inconsistency seems to be an issue.

The Global style and individual block-level styles should be applied to the same selectors to avoid issues like #50850, where the styles were not properly applied.

Step-by-step reproduction instructions

  1. Visit the FSE block editor.
  2. Add a table and update the global style of the table block.
  3. Update the padding and observe it being applied to <td>s.
  4. Then, visit any post.
  5. Add a table and update the padding of that table (block-level setting).
  6. Observe it being applied to the <figure> tag.

Screenshots, screen recording, code snippet

Block Editor (FSE, Global Styles)

image

Block Editor (Post, Block-Level Style)

image

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@faisal-alvi faisal-alvi added the [Type] Bug An existing feature does not function as intended label Feb 28, 2024
@jordesign jordesign added Needs Testing Needs further testing to be confirmed. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Feb 28, 2024
Copy link

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Mar 30, 2024
@miminari miminari added the [Block] Table Affects the Table Block label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants