Pattern Inserter: the panel re-renders after inserting a pattern and doesn't close after clicking on canvas

[miksansegundo]

Description

The pattern inserter panel re-renders multiple times after inserting a pattern and does not close after clicking on the canvas.

Step-by-step reproduction instructions

• Make sure Gutenberg 17.6 is activated
• Visit the site editor
• Open the Pattern Inserter "[+]" from the top bar
• Click the "About" category and then click on any pattern
• Expect to see the panel flashing multiple times
• Click on any block on the editor canvas
• Expect to see the panel flashing multiple times again when it should close
• Deactivate Gutenberg 17.6 and repeat the steps to verify the issue is not reproducible

Screenshots, screen recording, code snippet

Environment info

• WordPress 6.4
• Gutenberg 17.6
• Google Chromer 120
• MacOS Sonoma 14.1.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

[ntsekouras]

Thanks for the issue @miksansegundo! I couldn't reproduce on trunk right now 🤔 . @Mamaduka could you reproduce this?

[Mamaduka]

I can't reproduce it either on the latest trunk (60fc52d) + WP 6.4.x.

I'm unsure which commit fixed it. The #58661 was supposed to be a fix.

Update: Probably was fixed via #58813.

[ellatrix]

#58813 couldn't have been the fix because it's a different UI that was fixed there. I'm guessing it occurs inconsistently? There's been no fix, so this will probably appear again?