Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Columns adding block only available on left and right seems stuck #5772

Closed
karmatosed opened this issue Mar 23, 2018 · 11 comments
Closed

Columns adding block only available on left and right seems stuck #5772

karmatosed opened this issue Mar 23, 2018 · 11 comments
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended
Milestone

Comments

@karmatosed
Copy link
Member

I was using Chrome and got the following interesting formatting happening using the column block and 2 columns.

2018-03-23 at 22 15

Once I added blocks I could only add to one side:

2018-03-23 at 22 17

@karmatosed
Copy link
Member Author

This still happens on trunk

2018-04-05 at 17 25

@aduth
Copy link
Member

aduth commented Apr 5, 2018

In my testing, this occurs only when focus is not within the second column when using the inserter.

@ZebulanStanphill
Copy link
Member

This is still happening in master and Gutenberg 3.2.

@aduth aduth added the [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P label Jul 16, 2018
@ZebulanStanphill
Copy link
Member

Still happening in Gutenberg 3.6.2 and master.

@aduth
Copy link
Member

aduth commented Aug 20, 2018

For clarity's sake, could we get a simple set of reproducible steps here?

Based on the re-reading of the original comment, I'm left to wonder if this is the difference of the default appender being visible only after non-default block (i.e. won't show if the last in a column is Paragraph, which is expected, same as in top-level editor).

Given my previous response, I'm assuming I did find some legitimate issue to exist, though in revisiting it's not exactly obvious what's wrong / expected, and more information could help make this issue actionable.

@aduth aduth added the [Status] Needs More Info Follow-up required in order to be actionable. label Aug 20, 2018
@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Aug 20, 2018

@aduth Inserting a block places a block in the same context as where the text cursor is at.

If my text cursor is in a block outside of the Columns block, using the inserter on the right column will insert a block outside of the Columns block.

If my text cursor is in the left column, using the inserter on the right column will insert a block in the left column.

@designsimply
Copy link
Member

I was unable to reproduce the problem using the following testing steps:

  1. Add a columns block with at least one paragraph block with content in each column.
  2. Add a gallery block below the columns block.
  3. Place the cursor in the paragraph block in the left column.
  4. Click the sibling inserter for the paragraph block in the right column.

Result: I was able to use the sibling inserter to add a new nested block without any trouble. (34s)

nested-block-sibling-inserter-test
Seen at http://alittletestblog.com/wp-admin/post.php?post=14967&action=edit running WordPress 4.9.8 and Gutenberg 3.9.0-rc.1 using Firefox 62.0 on macOS 10.13.6.

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Sep 18, 2018

@designsimply The issue does not occur with the sibling inserter. You need to use the inserter that appears in the placeholder automatically created below a non-Paragraph block. Also, your text cursor has to be in the other column when you use the inserter. Please re-open. I can confirm this is still happening in master.

@designsimply
Copy link
Member

Apologies for not seeing your last comment earlier @ZebulanStanphill! Things have changed a bit since your last reply, so I re-tested just now using WordPress 5.0.3 and no active plugins using the following steps (with the testing steps modified per your note) and I think the issue has been resolved.

  1. Add a columns block with at least one paragraph block with content in each column.
  2. Add a gallery block below the columns block.
  3. Place the cursor in the paragraph block in the right column (this will create a default block below it).
  4. Place the cursor in the paragraph block in the left column.
  5. Click the inserter on the default block below the paragraph block in the right column.

5772-11s

I'd be happy to loop back around to test again if you spot anything off in the testing steps!

@ZebulanStanphill
Copy link
Member

@designsimply I am also unable to reproduce the issue in Gutenberg 5.0 on WordPress 5.0.3, so it looks like the issue has been fixed! 😄

@silaskoehler
Copy link

Describe the bug
I still have the same problem in Wordpress 5.1 (without any plugins, Theme: Twenty Nineteen).
I try to add a block to the right column and it appears in the left column.

To Reproduce

  1. add a columns block to the page.
  2. click on the right cross in the right column and add a heading block. ( both columns are empty until here)

Image of the Bug

Expected behavior
the heading block should be insert in the right colum.

When i first click in the right column and then try to add a block with the plus at the right side of that column, everything works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] Needs More Info Follow-up required in order to be actionable. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants