-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content blocks need to be labeled #562
Comments
Any of the information registered by a block could be made available in the DOM for the block listing. There might be some localization considerations here too, perhaps a label like: "Editor block: Image", etc ? |
Yep, or that or dedicated labels as the ones that must be provided for CPT registration, for example. |
Thinking also at #666 (backspace to remove a block)
Maybe an option could be allowing both the outer container and the inner editable to be focused when tabbing through blocks. This is already possible when tabbing backwards. Quick video to highlight focusable elements while tabbing forwards and backwards through blocks: To reproduce the current behavior:
It would be interesting to evaluate to make the outer container focusable also when tabbing forward. In this scenario, the toolbar should be excluded from the tab sequence and a possible flow would be:
Same when tabbing backwards. Seems to me it would make sense to make the outer container easily reachable with a keyboard, since some actions are available only on the outer container, e.g.
It would be sort of splitting controls in two different "layers", the outer one for actions specific to the block, the inner one for actions specific to the content. |
Worth noting also other editable regions need to be labeled. For example the image caption is a contenteditable figcaption, but has no label at all. When entering there, there's no feedback about what it is. |
When navigating through content blocks, assistive technologies need to report and inform users about what kind of block they just landed on. Content blocks need to be labeled someway, an din a way that screen readers can announce properly.
Currently, there's nothing that can be announced in the markup. Blocks are just always the same:
Maybe, and aria-label attribute on the focusable blocks (with an appropriate text to report the type of blocks) could help. This should be carefully tested though.
This relates also to #557 where the block mover should announce which kind of block it relates to.
Maybe, each block should carry a set of meta information available to be reused in other context. I see the state contains information about the blocks UID so maybe it should also contain a human-understandable name for each kind of blocks, to start with.
The text was updated successfully, but these errors were encountered: