Theme.json registered patterns missing in the Site Editor patterns view

[richtabor]

TT4 adds two patterns via theme.json, which are available within the Inserter, but omitted from the Site Editor > Patterns view. I'd expect that the theme's patterns should each be listed in the Site Editor > Patterns view.

In the first screenshot, the 'clients-section' pattern is missing, but in the inserter, you can see it properly.

Related to #55109

[glendaviesnz]

I see the clients pattern in the site editor on trunk:

I wonder what is different on your setup @richtabor ?

[t-hamano]

I tested it on the latest WordPress trunk and Gutenberg trunk, and I'm also seeing the same thing as @richtabor , but I think this is due to the difference in the specifications of the inserter and pattern page.

• Inserter: Displays all themes and plugins, user patterns, and patterns from the pattern directory
• Site editor patterns page: themes and plugins, user patterns

If you compare the number of patterns belonging to each category on the inserter and the pattern page, you will notice that the numbers are different.

Patterns defined in the patterns property of TT4's theme.json are categorized in the patterns directory in the inserter.

three-columns-of-services

clients-section

I don't know why @glendaviesnz can't reproduce this problem, but if the specification is that the pattern defined in the pattern property of theme.json is classified as a pattern directory source, I think this is the intended behavior.

[glendaviesnz]

I did a fresh install of TT4 on a site and was then seeing the same thing. @aaronrobertshaw can you remember the reasoning for not including these theme patterns in the site editor?

If we decide that we want these theme.json specified patterns to appear in the site editor this PR makes this change.

[aaronrobertshaw]

@aaronrobertshaw can you remember the reasoning for not including these theme patterns in the site editor?

My recollection was that no pattern directory patterns were to be included in the Site Editor patterns page. If I follow the examples correctly, the TT4 patterns in question are remote patterns from the pattern directory and so given previous decisions omitted from the patterns page.

There was a plan to eventually allow remote patterns to be linked to from the Site Editor's Patterns page allowing users to copy those patterns to their local user-created patterns to manage further like those provided via files in a theme.

If we decide that we want these theme.json specified patterns to appear in the site editor #55877 makes this change.

I also have a vague recollection of there being some issues with nested remote patterns so it might be more involved than simply deleting the pattern-directory/theme source from the core patterns list.