Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font Library: Consider clarifying which fonts are uploaded vs theme provided in modal #55220

Closed
Tracked by #60528
annezazu opened this issue Oct 10, 2023 · 7 comments
Closed
Tracked by #60528
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Pulling in feedback from the FSE Outreach Program's Final Touches call for testing:

Regarding the Fonts manager having a heading above the external/uploaded fonts. There is a heading that says Theme Fonts and one sees the fonts below it. Nice and clear. After uploading one or more fonts these are added above the Theme fonts section. I missing having a heading above uploaded fonts which clearly tells me what these fonts are. As in:

Heading: Uploaded/External Fonts.
Fuggles
etc

Heading: Theme Fonts.
DM Sans
IBM Plex Mono
etc

As these become like sections inside the Fonts Manager Library. Uploaded Fonts and Theme Fonts. Showing which fonts belong to each.

Right now, after uploading a font, it's not clear which comes from the theme vs uploaded separately. There's an argument to be had that this can make it easier for folks to just do what they want to do with fonts without worrying about that kind of separation but I can also see why folks might want to know what came with the theme vs what they are customizing.

@colorful-tones
Copy link
Member

I added #58403 to reinforce any work that might be done here and surface it in the Global Styles > Typography. This would reduce site builders of having to even launch the Font Library modal to see the different sources of where fonts were installed, e.g. Theme, User, etc.

@t-hamano
Copy link
Contributor

t-hamano commented Feb 9, 2024

#58834 will solve this problem.

@t-hamano
Copy link
Contributor

I have added this issue to WP6.5 project board. See this comment for the reason.

@annezazu annezazu moved this from 🔎 Needs Review to 🏗️ In Progress in WordPress 6.5 Editor Tasks Feb 26, 2024
@youknowriad
Copy link
Contributor

Moved this to 6.6 because it's an enhancement that can land later which will allow us to focus on the main font library issues for 6.5.

@creativecoder creativecoder changed the title Font Library: Consider clarifying which fonts are uploaded vs theme provided in drop down Font Library: Consider clarifying which fonts are uploaded vs theme provided in modal Apr 6, 2024
@afercia
Copy link
Contributor

afercia commented Apr 11, 2024

having a heading above the external/uploaded fonts.

Totally agree. I think this was also mentioned in other conversatios as well as an accessibility issue as any section of content should be clearly identified by a heading. These are lists of content items. It's not clear why one of the list does have a heading and the other doesn't.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Apr 11, 2024
@t-hamano
Copy link
Contributor

In the latest Font Library, the text for headings exists in both font lists. Should we change "Installed Fonts" to another text?

image

By the way, accessibility improvements should be addressed by #58834.

@annezazu
Copy link
Contributor Author

I dig this! I think installed fonts works great. I think we can close this out if I'm understanding correctly. Let me know and I can reopen too. At least on my end, this addresses the distinction between the two for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Font Library [Feature] Typography Font and typography-related issues and PRs [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Status: Done
Development

No branches or pull requests

6 participants