Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: implement levels of indent buttons #549

Closed
mtias opened this issue Apr 28, 2017 · 13 comments
Closed

List: implement levels of indent buttons #549

mtias opened this issue Apr 28, 2017 · 13 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Apr 28, 2017

To create nested lists and sub-levels.

@mtias mtias added [Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 28, 2017
@mtias mtias added this to the Prototype Parity milestone Apr 28, 2017
@mtias mtias modified the milestones: May Week 1, Prototype Parity May 1, 2017
@ellatrix
Copy link
Member

ellatrix commented May 4, 2017

For this one we probably need the TinyMCE list plugin for now, which gives us these additional commands.

@mtias
Copy link
Member Author

mtias commented May 4, 2017

Should we couple Editable with that plugin or can we make a wrapper around it that is specific for List blocks?

@ellatrix
Copy link
Member

ellatrix commented May 4, 2017

We can either just add it for all Editable instances, or allow the block to change the plugins... I'm thinking for now it's fine to just add it to all?

@ellatrix
Copy link
Member

ellatrix commented May 4, 2017

Ah I see what you mean with adding the buttons... The plugin will come with the shortcuts working already. Somehow we'll need to tie the commands to the buttons.

@BoardJames BoardJames self-assigned this May 5, 2017
@BoardJames
Copy link

In my current prototype I'm using tinymce.activeEditor to apply commands on the editor. I would like a better way if anyone has suggestions. Currently the only alternative I can think of is moving the indent/outdent code to the Editable like the alignment.

@BoardJames
Copy link

@jasmussen Are there plans for an isEnabled function for control buttons? I see in the blocks/README.md it mentions an isVisible function but that wouldn't be as useful for indent buttons.

@jasmussen
Copy link
Contributor

Are there plans for an isEnabled function for control buttons? I see in the blocks/README.md it mentions an isVisible function but that wouldn't be as useful for indent buttons.

If we need it, we'll make it happen, is what I think. Could you ask @iseulde as well? She's our resident super expert on this stuff. She hangs out in #core-editor also.

@BoardJames
Copy link

The downside of the TinyMCE list plugin is that is captures tab keys to do list indenting which means that tab navigation stops working. :-( I'm still trying to find a way around this limitation.

@BoardJames
Copy link

I've submitted a pull request for this feature:
#717
There are still some unresolved issues like how to tie the commands to buttons in nicer ways than using the global tinymce.activeEditor. There is also the known tab navigation issue caused by the lists plugin which I hope to fix on the TinyMCE side.

@aduth
Copy link
Member

aduth commented May 26, 2017

Considering this resolved by #717

@aduth aduth closed this as completed May 26, 2017
@jb510
Copy link

jb510 commented May 29, 2017

Apologies I'm having trouble finding somewhere appropriate for this feedback, but... I find not having tab function as indent (like it does in nearly every GUI) to be extremely confusing. That UI needs to get dropped for lots of reasons, along with rearranging blocks (those arrows drive me mad). Anyway, commenting here because it's related to tabs, but I really hope overriding the default keyboard shortcut for indenting lists isn't the ultimate solution here.

@BE-Webdesign
Copy link
Contributor

@jb510

Tab support for list indentation can definitely be added in. I recommend opening a new issue. In the title state the need ( tab support for list indentation ). It is important to understand that Gutenberg is in active development, and is not fully polished yet.

If there is any common/standard functionality you feel is missing, chronicling each item in the issue tracker is of great help. Keep each issue focused and concise. If you have any questions, feel free to add a Question: issue or join the #core-editor slack channel.

@BoardJames
Copy link

@jb510 @BE-Webdesign The tab key was doing list indentation but I was told that it broke accessibility so it got disabled. It is very easy to re-enable it but you can't navigate out of the list block using the keyboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

7 participants