Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Lightbox value at block-level should inherit top-level setting #54544

Closed
michalczaplinski opened this issue Sep 18, 2023 · 1 comment
Closed

Image: Lightbox value at block-level should inherit top-level setting #54544

michalczaplinski opened this issue Sep 18, 2023 · 1 comment
Labels
[Block] Image Affects the Image Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Bug An existing feature does not function as intended

Comments

@michalczaplinski
Copy link
Contributor

michalczaplinski commented Sep 18, 2023 •
edited
Loading

If you set the following in your theme.json:

"settings": {
    "lightbox": {
        "enabled": true
    },
}

the Lightbox inherits enabled at the Global Styles level but not the block editor level in the UI, and also doesn’t work on the frontend.
@michalczaplinski michalczaplinski mentioned this issue Sep 18, 2023
Open
69 tasks
@michalczaplinski michalczaplinski added [Type] Enhancement A suggestion for improvement. [Block] Image Affects the Image Block [Feature] Interactivity API API to add frontend interactivity to blocks. labels Sep 18, 2023
@michalczaplinski michalczaplinski changed the title Make sure that the value for the lightbox from the Global Styles is reflected in the block's inspector controls Image: Lightbox value at block-level should inherit from Global Styles in the inspector controls Sep 18, 2023
@michalczaplinski michalczaplinski changed the title Image: Lightbox value at block-level should inherit from Global Styles in the inspector controls Image: Lightbox value at block-level should inherit top-level setting Sep 18, 2023
This was referenced Sep 19, 2023
Closed
Merged
@michalczaplinski michalczaplinski added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Sep 26, 2023
@artemiomorales artemiomorales mentioned this issue Sep 27, 2023
Open
@michalczaplinski
Copy link
Contributor Author

closed in favour of #54858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michalczaplinski