Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: add checks to global styles to only fetch & save the option(s) being edited #54495

Closed
Andrew-Starr opened this issue Sep 15, 2023 · 2 comments
Closed

Request: add checks to global styles to only fetch & save the option(s) being edited #54495

Andrew-Starr opened this issue Sep 15, 2023 · 2 comments
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.

Comments

@Andrew-Starr
Copy link

What problem does this address?

In the site editor, when making any changes in either Styles > Layout or Block > * > Dimensions, every possible combination of unrelated settings are being saved in the global styles.

What is your proposed solution?

When editing a styles element, add some extra check that makes sure to only fetch the style of the element being edited, and prevent other unrelated data being fetched.
@Andrew-Starr
Copy link
Author

Related issues
#53868
#53199
#52200
#51390
WordPress/create-block-theme#388

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Sep 15, 2023
@Andrew-Starr
Copy link
Author

Closing this as not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mamaduka @Andrew-Starr